1. Patchew
  2. QEMU
  3. View series

[PATCH] hw/i386/acpi-build: Fix a typo

Philippe Mathieu-Daudé posted 1 patch 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210908222157.2377282-1-philmd@redhat.com
There is a newer version of this series
hw/i386/acpi-build.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] hw/i386/acpi-build: Fix a typo
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago 
Fix 'hotplugabble' -> 'hotpluggabble' typo.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/acpi-build.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index d1f5fa3b5a5..478263e12c9 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
     PCMachineState *pcms = PC_MACHINE(machine);
     int nb_numa_nodes = machine->numa_state->num_nodes;
     NodeInfo *numa_info = machine->numa_state->nodes;
-    ram_addr_t hotplugabble_address_space_size =
+    ram_addr_t hotpluggabble_address_space_size =
         object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
                                 NULL);
 
@@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
      * Memory devices may override proximity set by this entry,
      * providing _PXM method if necessary.
      */
-    if (hotplugabble_address_space_size) {
+    if (hotpluggabble_address_space_size) {
         numamem = acpi_data_push(table_data, sizeof *numamem);
         build_srat_memory(numamem, machine->device_memory->base,
-                          hotplugabble_address_space_size, nb_numa_nodes - 1,
+                          hotpluggabble_address_space_size, nb_numa_nodes - 1,
                           MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
     }
 
-- 
2.31.1
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Volker Rümelin 2 years, 7 months ago 
> Fix 'hotplugabble' -> 'hotpluggabble' typo.

I'm convinced that the correct spelling is hotpluggable. Only the 
consonant g is doubled.

With best regards
Volker

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/i386/acpi-build.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d1f5fa3b5a5..478263e12c9 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>       PCMachineState *pcms = PC_MACHINE(machine);
>       int nb_numa_nodes = machine->numa_state->num_nodes;
>       NodeInfo *numa_info = machine->numa_state->nodes;
> -    ram_addr_t hotplugabble_address_space_size =
> +    ram_addr_t hotpluggabble_address_space_size =
>           object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
>                                   NULL);
>   
> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>        * Memory devices may override proximity set by this entry,
>        * providing _PXM method if necessary.
>        */
> -    if (hotplugabble_address_space_size) {
> +    if (hotpluggabble_address_space_size) {
>           numamem = acpi_data_push(table_data, sizeof *numamem);
>           build_srat_memory(numamem, machine->device_memory->base,
> -                          hotplugabble_address_space_size, nb_numa_nodes - 1,
> +                          hotpluggabble_address_space_size, nb_numa_nodes - 1,
>                             MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
>       }
>
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago 
On 9/10/21 8:54 PM, Volker Rümelin wrote:
>> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> 
> I'm convinced that the correct spelling is hotpluggable. Only the
> consonant g is doubled.

Lol I missed this part, thanks :>
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Ani Sinha 2 years, 7 months ago 
On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> On 9/10/21 8:54 PM, Volker Rümelin wrote:
> >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> >
> > I'm convinced that the correct spelling is hotpluggable. Only the
> > consonant g is doubled.
>
> Lol I missed this part, thanks :>


Oops my apologies. I also did not notice the double b.


>
>
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago 
On 9/11/21 3:33 AM, Ani Sinha wrote:
> On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> 
>     On 9/10/21 8:54 PM, Volker Rümelin wrote:
>     >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>     >
>     > I'm convinced that the correct spelling is hotpluggable. Only the
>     > consonant g is doubled.
> 
>     Lol I missed this part, thanks :>
> 
> 
> Oops my apologies. I also did not notice the double b.

Typoglycemia++
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Ani Sinha 2 years, 7 months ago 
On Sat, Sep 11, 2021 at 13:56 Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> On 9/11/21 3:33 AM, Ani Sinha wrote:
> > On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
> > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> >
> >     On 9/10/21 8:54 PM, Volker Rümelin wrote:
> >     >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
> >     >
> >     > I'm convinced that the correct spelling is hotpluggable. Only the
> >     > consonant g is doubled.
> >
> >     Lol I missed this part, thanks :>
> >
> >
> > Oops my apologies. I also did not notice the double b.
>
> Typoglycemia++


Will have to experiment with this

https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Ani Sinha 2 years, 7 months ago 
On Sat, Sep 11, 2021 at 15:24 Ani Sinha <ani@anisinha.ca> wrote:

>
>
> On Sat, Sep 11, 2021 at 13:56 Philippe Mathieu-Daudé <philmd@redhat.com>
> wrote:
>
>> On 9/11/21 3:33 AM, Ani Sinha wrote:
>> > On Sat, Sep 11, 2021 at 1:03 AM Philippe Mathieu-Daudé
>> > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
>> >
>> >     On 9/10/21 8:54 PM, Volker Rümelin wrote:
>> >     >> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>> >     >
>> >     > I'm convinced that the correct spelling is hotpluggable. Only the
>> >     > consonant g is doubled.
>> >
>> >     Lol I missed this part, thanks :>
>> >
>> >
>> > Oops my apologies. I also did not notice the double b.
>>
>> Typoglycemia++
>
>
> Will have to experiment with this
>
> https://www.tenderisthebyte.
> <https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/>
>
com/blog/2019/06/09/spell-checking-emacs/
> <https://www.tenderisthebyte.com/blog/2019/06/09/spell-checking-emacs/>
>

Maybe we could also add a spellchecker to checkpatch?
Re: [PATCH] hw/i386/acpi-build: Fix a typo
Posted by Ani Sinha 2 years, 7 months ago 

On Thu, 9 Sep 2021, Philippe Mathieu-Daudé wrote:

> Fix 'hotplugabble' -> 'hotpluggabble' typo.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Ani Sinha <ani@anisinha.ca>

> ---
>  hw/i386/acpi-build.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index d1f5fa3b5a5..478263e12c9 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1916,7 +1916,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>      PCMachineState *pcms = PC_MACHINE(machine);
>      int nb_numa_nodes = machine->numa_state->num_nodes;
>      NodeInfo *numa_info = machine->numa_state->nodes;
> -    ram_addr_t hotplugabble_address_space_size =
> +    ram_addr_t hotpluggabble_address_space_size =
>          object_property_get_int(OBJECT(pcms), PC_MACHINE_DEVMEM_REGION_SIZE,
>                                  NULL);
>
> @@ -2022,10 +2022,10 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)
>       * Memory devices may override proximity set by this entry,
>       * providing _PXM method if necessary.
>       */
> -    if (hotplugabble_address_space_size) {
> +    if (hotpluggabble_address_space_size) {
>          numamem = acpi_data_push(table_data, sizeof *numamem);
>          build_srat_memory(numamem, machine->device_memory->base,
> -                          hotplugabble_address_space_size, nb_numa_nodes - 1,
> +                          hotpluggabble_address_space_size, nb_numa_nodes - 1,
>                            MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED);
>      }
>
> --
> 2.31.1
>
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.