[PATCH] fw_cfg: add etc/msr_feature_control

Paolo Bonzini posted 1 patch 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210907170935.210428-1-pbonzini@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>
hw/nvram/fw_cfg.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] fw_cfg: add etc/msr_feature_control
Posted by Paolo Bonzini 2 years, 7 months ago
The file already existed, but nobody had noticed the warning until now.
Add it at the bottom, since that is where unknown files go in legacy mode.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/nvram/fw_cfg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 9b8dcca4ea..c06b30de11 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -878,6 +878,7 @@ static struct {
     { "etc/tpm/log", 150 },
     { "etc/acpi/rsdp", 160 },
     { "bootorder", 170 },
+    { "etc/msr_feature_control", 180 },
 
 #define FW_CFG_ORDER_OVERRIDE_LAST 200
 };
-- 
2.31.1


Re: [PATCH] fw_cfg: add etc/msr_feature_control
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago
On 9/7/21 7:09 PM, Paolo Bonzini wrote:
> The file already existed, but nobody had noticed the warning until now.
> Add it at the bottom, since that is where unknown files go in legacy mode.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/nvram/fw_cfg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 9b8dcca4ea..c06b30de11 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -878,6 +878,7 @@ static struct {
>      { "etc/tpm/log", 150 },
>      { "etc/acpi/rsdp", 160 },
>      { "bootorder", 170 },
> +    { "etc/msr_feature_control", 180 },

Fixes: 217f1b4a721 ("target-i386: Publish advised value of
MSR_IA32_FEATURE_CONTROL via fw_cfg")
?


Re: [PATCH] fw_cfg: add etc/msr_feature_control
Posted by Paolo Bonzini 2 years, 7 months ago
On 07/09/21 20:19, Philippe Mathieu-Daudé wrote:
> Fixes: 217f1b4a721 ("target-i386: Publish advised value of
> MSR_IA32_FEATURE_CONTROL via fw_cfg")

Yes, thanks.

Paolo


Re: [PATCH] fw_cfg: add etc/msr_feature_control
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago
On 9/8/21 7:47 AM, Paolo Bonzini wrote:
> On 07/09/21 20:19, Philippe Mathieu-Daudé wrote:
>> Fixes: 217f1b4a721 ("target-i386: Publish advised value of
>> MSR_IA32_FEATURE_CONTROL via fw_cfg")
> 
> Yes, thanks.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>