[v1] aspeed queue

[PULL 00/14] aspeed queue

Posted by Cédric Le Goater 2 years, 7 months ago

The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:

  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-aspeed-20210903

for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:

  hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)

----------------------------------------------------------------
Aspeed patches :

* MAC enablement fixes (Guenter)
* Watchdog  and pca9552 fixes (Andrew)
* GPIO fixes (Joel)
* AST2600A3 SoC and DPS310 models (Joel)
* New Fuji BMC machine (Peter)

----------------------------------------------------------------
Andrew Jeffery (3):
      watchdog: aspeed: Sanitize control register values
      watchdog: aspeed: Fix sequential control writes
      misc/pca9552: Fix LED status register indexing in pca955x_get_led()

Guenter Roeck (2):
      hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb
      hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a

Joel Stanley (6):
      hw: aspeed_gpio: Simplify 1.8V defines
      hw: aspeed_gpio: Clarify GPIO controller name
      arm/aspeed: rainier: Add i2c eeproms and muxes
      aspeed: Emulate the AST2600A3
      hw/misc: Add Infineon DPS310 sensor model
      arm/aspeed: Add DPS310 to Witherspoon and Rainier

Peter Delevoryas (3):
      hw/arm/aspeed: Initialize AST2600 UART clock selection registers
      hw/arm/aspeed: Allow machine to set UART default
      hw/arm/aspeed: Add Fuji machine type

 include/hw/arm/aspeed.h          |   1 +
 include/hw/arm/aspeed_soc.h      |   1 +
 include/hw/misc/aspeed_scu.h     |   2 +
 include/hw/watchdog/wdt_aspeed.h |   1 +
 hw/arm/aspeed.c                  | 178 +++++++++++++++++++++++++++++--
 hw/arm/aspeed_ast2600.c          |  14 +--
 hw/arm/aspeed_soc.c              |   8 +-
 hw/gpio/aspeed_gpio.c            |  97 +++++++++--------
 hw/misc/aspeed_scu.c             |  40 +++++--
 hw/misc/pca9552.c                |   2 +-
 hw/sensor/dps310.c               | 225 +++++++++++++++++++++++++++++++++++++++
 hw/watchdog/wdt_aspeed.c         |  26 ++++-
 hw/arm/Kconfig                   |   1 +
 hw/sensor/Kconfig                |   4 +
 hw/sensor/meson.build            |   1 +
 15 files changed, 525 insertions(+), 76 deletions(-)
 create mode 100644 hw/sensor/dps310.c

Re: [PULL 00/14] aspeed queue

Posted by Philippe Mathieu-Daudé 2 years, 7 months ago

Hi Peter,

On 9/3/21 9:40 PM, Cédric Le Goater wrote:
> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
> 
>   Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
> 
> are available in the Git repository at:
> 
>   https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
> 
> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
> 
>   hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
> 
> ----------------------------------------------------------------
> Aspeed patches :
> 
> * MAC enablement fixes (Guenter)
> * Watchdog  and pca9552 fixes (Andrew)
> * GPIO fixes (Joel)
> * AST2600A3 SoC and DPS310 models (Joel)
> * New Fuji BMC machine (Peter)
> 
> ----------------------------------------------------------------

> Peter Delevoryas (3):
>       hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>       hw/arm/aspeed: Allow machine to set UART default
>       hw/arm/aspeed: Add Fuji machine type

I have a pending question with the last patch, do you mind holding
this PR until it is resolved with Cédric and the patch author please?

Thanks,

Phil.

Re: [PULL 00/14] aspeed queue

Posted by Cédric Le Goater 2 years, 7 months ago

On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
> Hi Peter,
> 
> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>
>>   Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>
>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>
>>   hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>
>> ----------------------------------------------------------------
>> Aspeed patches :
>>
>> * MAC enablement fixes (Guenter)
>> * Watchdog  and pca9552 fixes (Andrew)
>> * GPIO fixes (Joel)
>> * AST2600A3 SoC and DPS310 models (Joel)
>> * New Fuji BMC machine (Peter)
>>
>> ----------------------------------------------------------------
> 
>> Peter Delevoryas (3):
>>       hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>       hw/arm/aspeed: Allow machine to set UART default
>>       hw/arm/aspeed: Add Fuji machine type
> 
> I have a pending question with the last patch, do you mind holding
> this PR until it is resolved with Cédric and the patch author please?
> 
> Thanks,
> 
> Phil.
> 

I guess we can drop the following from the commit log : 

	git clone https://github.com/facebook/openbmc
	cd openbmc
	./sync_yocto.sh
	source openbmc-init-build-env fuji build-fuji
	bitbake fuji-image
	dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
	dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
	    bs=1k conv=notrunc
	
	git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
	cd qemu
	./configure --target-list=arm-softmmu --disable-vnc
	make -j $(nproc)
	./build/arm-softmmu/qemu-system-arm \
	    -machine fuji-bmc \
	    -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
	    -serial stdio \
	    -nic user,hostfwd=::2222-:22
	sshpass -p 0penBmc ssh root@localhost -p 2222


Thanks,

C.

Re: [PULL 00/14] aspeed queue

Posted by Philippe Mathieu-Daudé 2 years, 7 months ago

On 9/4/21 7:33 AM, Cédric Le Goater wrote:
> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
>> Hi Peter,
>>
>> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>>
>>>   Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>   https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>>
>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>>
>>>   hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Aspeed patches :
>>>
>>> * MAC enablement fixes (Guenter)
>>> * Watchdog  and pca9552 fixes (Andrew)
>>> * GPIO fixes (Joel)
>>> * AST2600A3 SoC and DPS310 models (Joel)
>>> * New Fuji BMC machine (Peter)
>>>
>>> ----------------------------------------------------------------
>>
>>> Peter Delevoryas (3):
>>>       hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>>       hw/arm/aspeed: Allow machine to set UART default
>>>       hw/arm/aspeed: Add Fuji machine type
>>
>> I have a pending question with the last patch, do you mind holding
>> this PR until it is resolved with Cédric and the patch author please?
>>
>> Thanks,
>>
>> Phil.
>>
> 
> I guess we can drop the following from the commit log : 
> 
> 	git clone https://github.com/facebook/openbmc
> 	cd openbmc
> 	./sync_yocto.sh
> 	source openbmc-init-build-env fuji build-fuji
> 	bitbake fuji-image
> 	dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
> 	dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
> 	    bs=1k conv=notrunc
> 	
> 	git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
> 	cd qemu
> 	./configure --target-list=arm-softmmu --disable-vnc
> 	make -j $(nproc)
> 	./build/arm-softmmu/qemu-system-arm \
> 	    -machine fuji-bmc \
> 	    -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
> 	    -serial stdio \
> 	    -nic user,hostfwd=::2222-:22
> 	sshpass -p 0penBmc ssh root@localhost -p 2222

Sounds good. Eventually document that in docs/system/arm/aspeed.rst
in a follow up patch?

Regards,

Phil.

Re: [PULL 00/14] aspeed queue

Posted by Cédric Le Goater 2 years, 7 months ago

On 9/5/21 1:03 AM, Philippe Mathieu-Daudé wrote:
> On 9/4/21 7:33 AM, Cédric Le Goater wrote:
>> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
>>> Hi Peter,
>>>
>>> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>>>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>>>
>>>>   Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>>>
>>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>>>
>>>>   hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Aspeed patches :
>>>>
>>>> * MAC enablement fixes (Guenter)
>>>> * Watchdog  and pca9552 fixes (Andrew)
>>>> * GPIO fixes (Joel)
>>>> * AST2600A3 SoC and DPS310 models (Joel)
>>>> * New Fuji BMC machine (Peter)
>>>>
>>>> ----------------------------------------------------------------
>>>
>>>> Peter Delevoryas (3):
>>>>       hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>>>       hw/arm/aspeed: Allow machine to set UART default
>>>>       hw/arm/aspeed: Add Fuji machine type
>>>
>>> I have a pending question with the last patch, do you mind holding
>>> this PR until it is resolved with Cédric and the patch author please?
>>>
>>> Thanks,
>>>
>>> Phil.
>>>
>>
>> I guess we can drop the following from the commit log : 
>>
>> 	git clone https://github.com/facebook/openbmc
>> 	cd openbmc
>> 	./sync_yocto.sh
>> 	source openbmc-init-build-env fuji build-fuji
>> 	bitbake fuji-image
>> 	dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
>> 	dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
>> 	    bs=1k conv=notrunc
>> 	
>> 	git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
>> 	cd qemu
>> 	./configure --target-list=arm-softmmu --disable-vnc
>> 	make -j $(nproc)
>> 	./build/arm-softmmu/qemu-system-arm \
>> 	    -machine fuji-bmc \
>> 	    -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
>> 	    -serial stdio \
>> 	    -nic user,hostfwd=::2222-:22
>> 	sshpass -p 0penBmc ssh root@localhost -p 2222
> 
> Sounds good. Eventually document that in docs/system/arm/aspeed.rst
> in a follow up patch?
> 
> Regards,
> 
> Phil.
> 


Peter D, 

Could you please resend the "hw/arm/aspeed: Add Fuji machine type"
patch addressing Phil's comment. I will resend a PR with the 
update.

Thanks,

C.

Re: [PULL 00/14] aspeed queue

Posted by Peter Delevoryas 2 years, 7 months ago


> On Sep 5, 2021, at 1:51 AM, Cédric Le Goater <clg@kaod.org> wrote:
> 
> On 9/5/21 1:03 AM, Philippe Mathieu-Daudé wrote:
>>> On 9/4/21 7:33 AM, Cédric Le Goater wrote:
>>> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
>>>> Hi Peter,
>>>> 
>>>> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>>>>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>>>> 
>>>>>  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>>>> 
>>>>> are available in the Git repository at:
>>>>> 
>>>>>  https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>>>> 
>>>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>>>> 
>>>>>  hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>>>> 
>>>>> ----------------------------------------------------------------
>>>>> Aspeed patches :
>>>>> 
>>>>> * MAC enablement fixes (Guenter)
>>>>> * Watchdog  and pca9552 fixes (Andrew)
>>>>> * GPIO fixes (Joel)
>>>>> * AST2600A3 SoC and DPS310 models (Joel)
>>>>> * New Fuji BMC machine (Peter)
>>>>> 
>>>>> ----------------------------------------------------------------
>>>> 
>>>>> Peter Delevoryas (3):
>>>>>      hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>>>>      hw/arm/aspeed: Allow machine to set UART default
>>>>>      hw/arm/aspeed: Add Fuji machine type
>>>> 
>>>> I have a pending question with the last patch, do you mind holding
>>>> this PR until it is resolved with Cédric and the patch author please?
>>>> 
>>>> Thanks,
>>>> 
>>>> Phil.
>>>> 
>>> 
>>> I guess we can drop the following from the commit log : 
>>> 
>>>    git clone https://github.com/facebook/openbmc
>>>    cd openbmc
>>>    ./sync_yocto.sh
>>>    source openbmc-init-build-env fuji build-fuji
>>>    bitbake fuji-image
>>>    dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
>>>    dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
>>>        bs=1k conv=notrunc
>>>    
>>>    git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
>>>    cd qemu
>>>    ./configure --target-list=arm-softmmu --disable-vnc
>>>    make -j $(nproc)
>>>    ./build/arm-softmmu/qemu-system-arm \
>>>        -machine fuji-bmc \
>>>        -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
>>>        -serial stdio \
>>>        -nic user,hostfwd=::2222-:22
>>>    sshpass -p 0penBmc ssh root@localhost -p 2222
>> 
>> Sounds good. Eventually document that in docs/system/arm/aspeed.rst
>> in a follow up patch?
>> 
>> Regards,
>> 
>> Phil.
>> 
> 
> 
> Peter D, 
> 
> Could you please resend the "hw/arm/aspeed: Add Fuji machine type"
> patch addressing Phil's comment. I will resend a PR with the 
> update.
> 
> Thanks,
> 
> C. 
> 
> 

Oh! Yes, I can do that, sorry, I wasn’t sure if it was necessary to resend or if it could be fixed inline or something. I’ll send that within the next 24 hrs, removing the selected text from the commit description.

Thanks,
Peter

> 
> 
>

Re: [PULL 00/14] aspeed queue

Posted by Cédric Le Goater 2 years, 7 months ago

On 9/5/21 4:34 PM, Peter Delevoryas wrote:
> 
> 
>> On Sep 5, 2021, at 1:51 AM, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> On 9/5/21 1:03 AM, Philippe Mathieu-Daudé wrote:
>>>> On 9/4/21 7:33 AM, Cédric Le Goater wrote:
>>>> On 9/3/21 10:41 PM, Philippe Mathieu-Daudé wrote:
>>>>> Hi Peter,
>>>>>
>>>>> On 9/3/21 9:40 PM, Cédric Le Goater wrote:
>>>>>> The following changes since commit 8880cc4362fde4ecdac0b2092318893118206fcf:
>>>>>>
>>>>>>  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20210902' into staging (2021-09-03 08:27:38 +0100)
>>>>>>
>>>>>> are available in the Git repository at:
>>>>>>
>>>>>>  https://github.com/legoater/qemu/ tags/pull-aspeed-20210903
>>>>>>
>>>>>> for you to fetch changes up to 907796622b2a6b945c87641d94e254ac898b96ae:
>>>>>>
>>>>>>  hw/arm/aspeed: Add Fuji machine type (2021-09-03 18:43:16 +0200)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> Aspeed patches :
>>>>>>
>>>>>> * MAC enablement fixes (Guenter)
>>>>>> * Watchdog  and pca9552 fixes (Andrew)
>>>>>> * GPIO fixes (Joel)
>>>>>> * AST2600A3 SoC and DPS310 models (Joel)
>>>>>> * New Fuji BMC machine (Peter)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>
>>>>>> Peter Delevoryas (3):
>>>>>>      hw/arm/aspeed: Initialize AST2600 UART clock selection registers
>>>>>>      hw/arm/aspeed: Allow machine to set UART default
>>>>>>      hw/arm/aspeed: Add Fuji machine type
>>>>>
>>>>> I have a pending question with the last patch, do you mind holding
>>>>> this PR until it is resolved with Cédric and the patch author please?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Phil.
>>>>>
>>>>
>>>> I guess we can drop the following from the commit log : 
>>>>
>>>>    git clone https://github.com/facebook/openbmc
>>>>    cd openbmc
>>>>    ./sync_yocto.sh
>>>>    source openbmc-init-build-env fuji build-fuji
>>>>    bitbake fuji-image
>>>>    dd if=/dev/zero of=/tmp/fuji.mtd bs=1M count=128
>>>>    dd if=./tmp/deploy/images/fuji/flash-fuji of=/tmp/fuji.mtd \
>>>>        bs=1k conv=notrunc
>>>>    
>>>>    git clone --branch aspeed-next https://github.com/peterdelevoryas/qemu
>>>>    cd qemu
>>>>    ./configure --target-list=arm-softmmu --disable-vnc
>>>>    make -j $(nproc)
>>>>    ./build/arm-softmmu/qemu-system-arm \
>>>>        -machine fuji-bmc \
>>>>        -drive file=/tmp/fuji.mtd,format=raw,if=mtd \
>>>>        -serial stdio \
>>>>        -nic user,hostfwd=::2222-:22
>>>>    sshpass -p 0penBmc ssh root@localhost -p 2222
>>>
>>> Sounds good. Eventually document that in docs/system/arm/aspeed.rst
>>> in a follow up patch?
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>
>>
>> Peter D, 
>>
>> Could you please resend the "hw/arm/aspeed: Add Fuji machine type"
>> patch addressing Phil's comment. I will resend a PR with the 
>> update.
>>
>> Thanks,
>>
>> C. 
>>
>>
> 
> Oh! Yes, I can do that, sorry, I wasn’t sure if it was necessary to resend or if it could be fixed inline or something. I’ll send that within the next 24 hrs, removing the selected text from the commit description.

I didn't either. 

Thanks, 

C.