[v2] hw/virtio: Minor housekeeping patches

[PATCH v2 0/5] hw/virtio: Minor housekeeping patches

Philippe Mathieu-Daudé posted 5 patches 2 years, 7 months ago

Diff against v1 v3
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210902165039.432786-1-philmd@redhat.com

There is a newer version of this series

include/hw/virtio/virtio.h |  7 +++++++
hw/virtio/virtio.c         | 39 ++++++++++++++++++--------------------
2 files changed, 25 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH v2 0/5] hw/virtio: Minor housekeeping patches

Posted by Philippe Mathieu-Daudé 2 years, 7 months ago

Hi,

This series contains few patches I gathered while tooking notes
trying to understand issues #300-#302.

Since v1:
- Added virtqueue_flush comment (Stefano)
- Call RCU_READ_LOCK_GUARD in virtqueue_packed_drop_all (Stefano)

Philippe Mathieu-Daudé (5):
  hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU
  hw/virtio: Comment virtqueue_flush() must be called with RCU read lock
  hw/virtio: Remove NULL check in virtio_free_region_cache()
  hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all()
  hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees

 include/hw/virtio/virtio.h |  7 +++++++
 hw/virtio/virtio.c         | 39 ++++++++++++++++++--------------------
 2 files changed, 25 insertions(+), 21 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/5] hw/virtio: Minor housekeeping patches

Posted by Michael S. Tsirkin 2 years, 7 months ago

On Thu, Sep 02, 2021 at 06:50:34PM +0200, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series contains few patches I gathered while tooking notes
> trying to understand issues #300-#302.

v1 was includes in my pull request already, pls send
incremental patches on top. Thanks!

> Since v1:
> - Added virtqueue_flush comment (Stefano)
> - Call RCU_READ_LOCK_GUARD in virtqueue_packed_drop_all (Stefano)
> 
> Philippe Mathieu-Daudé (5):
>   hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU
>   hw/virtio: Comment virtqueue_flush() must be called with RCU read lock
>   hw/virtio: Remove NULL check in virtio_free_region_cache()
>   hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all()
>   hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees
> 
>  include/hw/virtio/virtio.h |  7 +++++++
>  hw/virtio/virtio.c         | 39 ++++++++++++++++++--------------------
>  2 files changed, 25 insertions(+), 21 deletions(-)
> 
> -- 
> 2.31.1
>