[PATCH v2 0/3] VNC-related HMP/QMP fixes

Stefan Reiter posted 3 patches 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210901151748.1712048-1-s.reiter@proxmox.com
Maintainers: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
There is a newer version of this series
hmp-commands.hx    | 29 +++++++++++++++--------------
monitor/hmp-cmds.c |  9 ++++++---
monitor/hmp.c      | 17 ++++++++++++++++-
monitor/qmp-cmds.c |  9 +++++----
qapi/ui.json       | 12 ++++++++++--
5 files changed, 52 insertions(+), 24 deletions(-)
[PATCH v2 0/3] VNC-related HMP/QMP fixes
Posted by Stefan Reiter 2 years, 7 months ago
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC access port, this means configuring a second VNC
display (in addition to our standard one for web-access), but it turns out one
cannot set a password on this second display at the moment, as the
'set_password' call only operates on the 'default' display.

Additionally, using secret objects, the password is only read once at startup.
This could be considered a bug too, but is not touched in this series and left
for a later date.


v1 -> v2:
* add Marc-André's R-b on patch 1
* use '-d' flag as suggested by Eric Blake and Gerd Hoffmann
  * I didn't see a way to do this yet, so I added a "flags with values" arg type


Stefan Reiter (3):
  monitor/hmp: correctly invert password argument detection again
  monitor/hmp: add support for flag argument with value
  monitor: allow VNC related QMP and HMP commands to take a display ID

 hmp-commands.hx    | 29 +++++++++++++++--------------
 monitor/hmp-cmds.c |  9 ++++++---
 monitor/hmp.c      | 17 ++++++++++++++++-
 monitor/qmp-cmds.c |  9 +++++----
 qapi/ui.json       | 12 ++++++++++--
 5 files changed, 52 insertions(+), 24 deletions(-)

-- 
2.30.2