docs/devel: be consistent about example plugin names

[PATCH] docs/devel: be consistent about example plugin names

Mahmoud Mandour posted 1 patch 2 years, 7 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210830121534.656559-1-ma.mandourr@gmail.com

Maintainers: Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, "Alex Bennée" <alex.bennee@linaro.org>

docs/devel/tcg-plugins.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] docs/devel: be consistent about example plugin names

Posted by Mahmoud Mandour 2 years, 7 months ago

Some plugins were prefixed with `.c`, some were not. Since the name is
essentially the full-name of the plugin file, it's logical to include
the extension.

Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
 docs/devel/tcg-plugins.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 047bf4ada7..f96aad4ae7 100644
--- a/docs/devel/tcg-plugins.rst
+++ b/docs/devel/tcg-plugins.rst
@@ -286,7 +286,7 @@ which will eventually report::
     previously @ 0x000000ffd08098/5 (809900593 insns)
     previously @ 0x000000ffd080c0/1 (809900588 insns)
 
-- contrib/plugins/hwprofile
+- contrib/plugins/hwprofile.c
 
 The hwprofile tool can only be used with system emulation and allows
 the user to see what hardware is accessed how often. It has a number of options:
@@ -345,7 +345,7 @@ which will output an execution trace following this structure::
   0, 0xd34, 0xf9c8f000, "bl #0x10c8"
   0, 0x10c8, 0xfff96c43, "ldr r3, [r0, #0x44]", load, 0x200000e4, RAM
 
-- contrib/plugins/cache
+- contrib/plugins/cache.c
 
 Cache modelling plugin that measures the performance of a given cache
 configuration when a given working set is run::
-- 
2.33.0

Re: [PATCH] docs/devel: be consistent about example plugin names

Posted by Alex Bennée 2 years, 7 months ago

Mahmoud Mandour <ma.mandourr@gmail.com> writes:

> Some plugins were prefixed with `.c`, some were not. Since the name is
> essentially the full-name of the plugin file, it's logical to include
> the extension.
>
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>

Queued to pr/010921-for-6.2-1, thanks.

-- 
Alex Bennée