[v2] dump-guest-memory: Add blocker for migration

[PATCH v2 0/3] dump-guest-memory: Add blocker for migration

Peter Xu posted 3 patches 2 years, 7 months ago

Diff against v1 v3
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210826185813.248441-1-peterx@redhat.com

Maintainers: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Juan Quintela <quintela@redhat.com>

There is a newer version of this series

dump/dump.c                 | 24 +++++++++++++++++++-----
include/migration/blocker.h | 16 ++++++++++++++++
migration/migration.c       | 24 +++++++++++++++---------
3 files changed, 50 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH v2 0/3] dump-guest-memory: Add blocker for migration

Posted by Peter Xu 2 years, 7 months ago

v2:
- One more patch: "migration: Make migration blocker work for snapshots too"
- Move register of migration blocker to be before dump_init [Marc-Andre]
- Collected r-bs

Both dump-guest-memory and live migration have vm state cached internally.
Allowing them to happen together means the vm state can be messed up.  Simply
block live migration for dump-guest-memory.

One trivial thing to mention is we should still allow dump-guest-memory even if
-only-migratable is specified, because that flag should majorly be used to
guarantee not adding devices that will block migration by accident.  Dump guest
memory is not like that - it'll only block for the seconds when it's dumping.

Thanks,

Peter Xu (3):
  migration: Make migration blocker work for snapshots too
  migration: Add migrate_add_blocker_internal()
  dump-guest-memory: Block live migration

 dump/dump.c                 | 24 +++++++++++++++++++-----
 include/migration/blocker.h | 16 ++++++++++++++++
 migration/migration.c       | 24 +++++++++++++++---------
 3 files changed, 50 insertions(+), 14 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/3] dump-guest-memory: Add blocker for migration

Posted by Peter Xu 2 years, 6 months ago

On Thu, Aug 26, 2021 at 02:58:10PM -0400, Peter Xu wrote:
> v2:
> - One more patch: "migration: Make migration blocker work for snapshots too"
> - Move register of migration blocker to be before dump_init [Marc-Andre]
> - Collected r-bs
> 
> Both dump-guest-memory and live migration have vm state cached internally.
> Allowing them to happen together means the vm state can be messed up.  Simply
> block live migration for dump-guest-memory.
> 
> One trivial thing to mention is we should still allow dump-guest-memory even if
> -only-migratable is specified, because that flag should majorly be used to
> guarantee not adding devices that will block migration by accident.  Dump guest
> memory is not like that - it'll only block for the seconds when it's dumping.

Ping?

-- 
Peter Xu