MAINTAINERS: Split Audio section

[PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6b3697962c1..9ec6baa7e4c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
 
 Devices
 -------
+Overall Audio frontends
+M: Gerd Hoffmann <kraxel@redhat.com>
+S: Odd Fixes
+F: hw/audio/
+F: include/hw/audio/
+F: tests/qtest/ac97-test.c
+F: tests/qtest/es1370-test.c
+F: tests/qtest/intel-hda-test.c
+F: tests/qtest/fuzz-sb16-test.c
+
 Xilinx CAN
 M: Vikram Garhwal <fnu.vikram@xilinx.com>
 M: Francisco Iglesias <francisco.iglesias@xilinx.com>
@@ -2256,17 +2266,11 @@ F: include/net/can_*.h
 
 Subsystems
 ----------
-Audio
+Overall Audio backends
 M: Gerd Hoffmann <kraxel@redhat.com>
 S: Odd Fixes
 F: audio/
-F: hw/audio/
-F: include/hw/audio/
 F: qapi/audio.json
-F: tests/qtest/ac97-test.c
-F: tests/qtest/es1370-test.c
-F: tests/qtest/intel-hda-test.c
-F: tests/qtest/fuzz-sb16-test.c
 
 Block layer core
 M: Kevin Wolf <kwolf@redhat.com>
-- 
2.31.1

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Christian Schoenebeck 4 years, 5 months ago

On Montag, 16. August 2021 21:10:12 CEST Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b3697962c1..9ec6baa7e4c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
> 
>  Devices
>  -------
> +Overall Audio frontends
> +M: Gerd Hoffmann <kraxel@redhat.com>
> +S: Odd Fixes
> +F: hw/audio/
> +F: include/hw/audio/
> +F: tests/qtest/ac97-test.c
> +F: tests/qtest/es1370-test.c
> +F: tests/qtest/intel-hda-test.c
> +F: tests/qtest/fuzz-sb16-test.c
> +

I would call that "Audio Hardware Emulation" instead of "Overall Audio 
frontends".

And probably it would make sense to further subdivide this section into the 
individual hardware models (Sound Blaster, Adlib, PC Speaker, VIA AC97, ...), 
similar to patch 3. Could be split subsequently as well of course.

>  Xilinx CAN
>  M: Vikram Garhwal <fnu.vikram@xilinx.com>
>  M: Francisco Iglesias <francisco.iglesias@xilinx.com>
> @@ -2256,17 +2266,11 @@ F: include/net/can_*.h
> 
>  Subsystems
>  ----------
> -Audio
> +Overall Audio backends
>  M: Gerd Hoffmann <kraxel@redhat.com>
>  S: Odd Fixes
>  F: audio/
> -F: hw/audio/
> -F: include/hw/audio/
>  F: qapi/audio.json
> -F: tests/qtest/ac97-test.c
> -F: tests/qtest/es1370-test.c
> -F: tests/qtest/intel-hda-test.c
> -F: tests/qtest/fuzz-sb16-test.c
> 
>  Block layer core
>  M: Kevin Wolf <kwolf@redhat.com>

Likewise I would call this section "Shared/common QEMU audio library/
subsystem" or something like that instead of "Overall Audio backends".

Best regards,
Christian Schoenebeck

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Gerd Hoffmann 4 years, 5 months ago

  Hi,

> > +Overall Audio frontends

> I would call that "Audio Hardware Emulation" instead of "Overall Audio 
> frontends".

> > +Overall Audio backends

> Likewise I would call this section "Shared/common QEMU audio library/
> subsystem" or something like that instead of "Overall Audio backends".

Well, frontend/backend is common qemu terminology, with "frontend" being
the emulated/virtual device as seen by the guest and "backend" being the 
host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

take care,
  Gerd

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Christian Schoenebeck 4 years, 5 months ago

On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
>   Hi,
> 
> > > +Overall Audio frontends
> > 
> > I would call that "Audio Hardware Emulation" instead of "Overall Audio
> > frontends".
> > 
> > > +Overall Audio backends
> > 
> > Likewise I would call this section "Shared/common QEMU audio library/
> > subsystem" or something like that instead of "Overall Audio backends".
> 
> Well, frontend/backend is common qemu terminology, with "frontend" being
> the emulated/virtual device as seen by the guest and "backend" being the
> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
> 
> take care,
>   Gerd

Yeah, I was seeing this (like usual) more from an external/new developer 
perspective where the semantic for "frontend"/"backend" is not that obvious 
here.

But okay ...

Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

On 8/17/21 6:12 PM, Christian Schoenebeck wrote:
> On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
>>   Hi,
>>
>>>> +Overall Audio frontends
>>>
>>> I would call that "Audio Hardware Emulation" instead of "Overall Audio
>>> frontends".
>>>
>>>> +Overall Audio backends
>>>
>>> Likewise I would call this section "Shared/common QEMU audio library/
>>> subsystem" or something like that instead of "Overall Audio backends".
>>
>> Well, frontend/backend is common qemu terminology, with "frontend" being
>> the emulated/virtual device as seen by the guest and "backend" being the
>> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
>>
>> take care,
>>   Gerd
> 
> Yeah, I was seeing this (like usual) more from an external/new developer 
> perspective where the semantic for "frontend"/"backend" is not that obvious 
> here.

"Audio Backends" is in the "Subsystems" meta-section, and
"Audio Frontends" in the "Devices" one.

Maybe we using the === separator for meta-sections (like rST)
instead of --- would help seeing the difference.

I don't want to use parenthesis in the descriptions because
this then breaks the get_maintainer.pl output when parsed
by (git) scripts.

> 
> But okay ...
> 
> Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> 
> Best regards,
> Christian Schoenebeck
> 
>

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Posted by Christian Schoenebeck 4 years, 5 months ago

On Dienstag, 17. August 2021 19:57:21 CEST Philippe Mathieu-Daudé wrote:
> On 8/17/21 6:12 PM, Christian Schoenebeck wrote:
> > On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:
> >>   Hi,
> >>   
> >>>> +Overall Audio frontends
> >>> 
> >>> I would call that "Audio Hardware Emulation" instead of "Overall Audio
> >>> frontends".
> >>> 
> >>>> +Overall Audio backends
> >>> 
> >>> Likewise I would call this section "Shared/common QEMU audio library/
> >>> subsystem" or something like that instead of "Overall Audio backends".
> >> 
> >> Well, frontend/backend is common qemu terminology, with "frontend" being
> >> the emulated/virtual device as seen by the guest and "backend" being the
> >> host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)
> >> 
> >> take care,
> >> 
> >>   Gerd
> > 
> > Yeah, I was seeing this (like usual) more from an external/new developer
> > perspective where the semantic for "frontend"/"backend" is not that
> > obvious
> > here.
> 
> "Audio Backends" is in the "Subsystems" meta-section, and
> "Audio Frontends" in the "Devices" one.
> 
> Maybe we using the === separator for meta-sections (like rST)
> instead of --- would help seeing the difference.

No need for now. On the long-term the MAINTAINERS structure might be improved 
in some way to make specific tree structures more clear, but for now it's Ok.

Thanks!

Best regards,
Christian Schoenebeck