MAINTAINERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
I have changed my name and email address. Update the MAINTAINERS file
to match.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
MAINTAINERS | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 37b1a8e442..694973ed23 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2270,7 +2270,7 @@ F: tests/qtest/fuzz-sb16-test.c
Block layer core
M: Kevin Wolf <kwolf@redhat.com>
-M: Max Reitz <mreitz@redhat.com>
+M: Hanna Reitz <hreitz@redhat.com>
L: qemu-block@nongnu.org
S: Supported
F: block*
@@ -3265,7 +3265,7 @@ F: stubs/io_uring.c
qcow2
M: Kevin Wolf <kwolf@redhat.com>
-M: Max Reitz <mreitz@redhat.com>
+M: Hanna Reitz <hreitz@redhat.com>
L: qemu-block@nongnu.org
S: Supported
F: block/qcow2*
@@ -3279,7 +3279,7 @@ F: block/qcow.c
blkdebug
M: Kevin Wolf <kwolf@redhat.com>
-M: Max Reitz <mreitz@redhat.com>
+M: Hanna Reitz <hreitz@redhat.com>
L: qemu-block@nongnu.org
S: Supported
F: block/blkdebug.c
@@ -3314,7 +3314,7 @@ F: tests/qtest/vhost-user-blk-test.c
F: util/vhost-user-server.c
FUSE block device exports
-M: Max Reitz <mreitz@redhat.com>
+M: Hanna Reitz <hreitz@redhat.com>
L: qemu-block@nongnu.org
S: Supported
F: block/export/fuse.c
--
2.31.1
On 8/10/21 11:50 AM, Hanna Reitz wrote: > I have changed my name and email address. Update the MAINTAINERS file > to match. > > Signed-off-by: Hanna Reitz <hreitz@redhat.com> > --- > MAINTAINERS | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) I'd recommend you to also add an entry in .mailmap: -- >8 -- diff --git a/.mailmap b/.mailmap index 082ff893ab3..504839c84d3 100644 --- a/.mailmap +++ b/.mailmap @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony Liguori <aliguori@us.ibm.com> Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> --- As it or with .mailmap modified: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 10.08.21 13:29, Philippe Mathieu-Daudé wrote: > On 8/10/21 11:50 AM, Hanna Reitz wrote: >> I have changed my name and email address. Update the MAINTAINERS file >> to match. >> >> Signed-off-by: Hanna Reitz <hreitz@redhat.com> >> --- >> MAINTAINERS | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) > I'd recommend you to also add an entry in .mailmap: > > -- >8 -- > diff --git a/.mailmap b/.mailmap > index 082ff893ab3..504839c84d3 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony > Liguori <aliguori@us.ibm.com> > Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> > Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> > Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> > +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> > Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> > Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> > James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> > --- Hu, I didn’t know there is such a thing. Looks like I could even do Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com> Feels a bit like cheating, though...? > As it or with .mailmap modified: > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 8/10/21 1:46 PM, Hanna Reitz wrote: > On 10.08.21 13:29, Philippe Mathieu-Daudé wrote: >> On 8/10/21 11:50 AM, Hanna Reitz wrote: >>> I have changed my name and email address. Update the MAINTAINERS file >>> to match. >>> >>> Signed-off-by: Hanna Reitz <hreitz@redhat.com> >>> --- >>> MAINTAINERS | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >> I'd recommend you to also add an entry in .mailmap: >> >> -- >8 -- >> diff --git a/.mailmap b/.mailmap >> index 082ff893ab3..504839c84d3 100644 >> --- a/.mailmap >> +++ b/.mailmap >> @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony >> Liguori <aliguori@us.ibm.com> >> Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> >> Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> >> Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> >> +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> >> Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> >> Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> >> James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> >> --- > > Hu, I didn’t know there is such a thing. Looks like I could even do > > Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com> If you want to restrict to 'Max Reitz', but without it it will simply take all mails from <mreitz@>. IMO KISS, no need to filter by name in your case :) > Feels a bit like cheating, though...? No, why? The "preferred name forms" section seems adequate. >> As it or with .mailmap modified: >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> What is nice with .mailmap is the combination with ./get_maintainers.pl, in particular when it defaults looking at commit history. If you Sob/Acked a commit as Max, the script (call by git-send-email) will replace it by Hanna. For the contribution statistics, all your previous contributions as Max will be directly shown as Hanna (along with your future ones).
On 10.08.21 14:18, Philippe Mathieu-Daudé wrote: > On 8/10/21 1:46 PM, Hanna Reitz wrote: >> On 10.08.21 13:29, Philippe Mathieu-Daudé wrote: >>> On 8/10/21 11:50 AM, Hanna Reitz wrote: >>>> I have changed my name and email address. Update the MAINTAINERS file >>>> to match. >>>> >>>> Signed-off-by: Hanna Reitz <hreitz@redhat.com> >>>> --- >>>> MAINTAINERS | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> I'd recommend you to also add an entry in .mailmap: >>> >>> -- >8 -- >>> diff --git a/.mailmap b/.mailmap >>> index 082ff893ab3..504839c84d3 100644 >>> --- a/.mailmap >>> +++ b/.mailmap >>> @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony >>> Liguori <aliguori@us.ibm.com> >>> Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> >>> Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> >>> Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> >>> +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> >>> Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> >>> Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> >>> James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> >>> --- >> Hu, I didn’t know there is such a thing. Looks like I could even do >> >> Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com> > If you want to restrict to 'Max Reitz', but without it it will simply > take all mails from <mreitz@>. IMO KISS, no need to filter by name in > your case :) Oh, right. I thought not giving the name would only replace the email address, for some reason. >> Feels a bit like cheating, though...? > No, why? The "preferred name forms" section seems adequate. Well. It’s not exactly a preferred name form, is it. But it is a case of “git author config” change, so I suppose it fits best. >>> As it or with .mailmap modified: >>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > What is nice with .mailmap is the combination with ./get_maintainers.pl, > in particular when it defaults looking at commit history. If you > Sob/Acked a commit as Max, the script (call by git-send-email) will > replace it by Hanna. That almost sounds like a reason not to do it. You know, so I can deny any involvement on maintainer-less files. O:) > For the contribution statistics, all your previous contributions as Max > will be directly shown as Hanna (along with your future ones). OK, well, if you insist. :) Hanna
On Tue, Aug 10, 2021 at 01:46:51PM +0200, Hanna Reitz wrote: > On 10.08.21 13:29, Philippe Mathieu-Daudé wrote: > > On 8/10/21 11:50 AM, Hanna Reitz wrote: > > > I have changed my name and email address. Update the MAINTAINERS file > > > to match. > > > > > > Signed-off-by: Hanna Reitz <hreitz@redhat.com> > > > --- > > > MAINTAINERS | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > I'd recommend you to also add an entry in .mailmap: > > > > -- >8 -- > > diff --git a/.mailmap b/.mailmap > > index 082ff893ab3..504839c84d3 100644 > > --- a/.mailmap > > +++ b/.mailmap > > @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony > > Liguori <aliguori@us.ibm.com> > > Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> > > Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> > > Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> > > +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> > > Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> > > Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> > > James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> > > --- > > Hu, I didn’t know there is such a thing. Looks like I could even do > > Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com> With the line Philippe suggested, the rewrite will happen any time the original email is seen. With this line, the rewrite will only happen if both original name + email match. In practice this is functionally the same, unless someone had variations in the spelling of their real name over time, so either would work. > Feels a bit like cheating, though...? I wouldn't call it cheating. It is just an input for canonicalizing contributors' identities, where there were changes in name or email over time. It gives a more useful view to tools like 'git shortlog' and 'git-dm' stats reports, such that all work over time will be grouped together instead of split. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 10.08.21 14:31, Daniel P. Berrangé wrote: > On Tue, Aug 10, 2021 at 01:46:51PM +0200, Hanna Reitz wrote: >> On 10.08.21 13:29, Philippe Mathieu-Daudé wrote: >>> On 8/10/21 11:50 AM, Hanna Reitz wrote: >>>> I have changed my name and email address. Update the MAINTAINERS file >>>> to match. >>>> >>>> Signed-off-by: Hanna Reitz <hreitz@redhat.com> >>>> --- >>>> MAINTAINERS | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> I'd recommend you to also add an entry in .mailmap: >>> >>> -- >8 -- >>> diff --git a/.mailmap b/.mailmap >>> index 082ff893ab3..504839c84d3 100644 >>> --- a/.mailmap >>> +++ b/.mailmap >>> @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony >>> Liguori <aliguori@us.ibm.com> >>> Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com> >>> Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com> >>> Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com> >>> +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com> >>> Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com> >>> Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn> >>> James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com> >>> --- >> Hu, I didn’t know there is such a thing. Looks like I could even do >> >> Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com> > With the line Philippe suggested, the rewrite will happen any time > the original email is seen. With this line, the rewrite will only > happen if both original name + email match. In practice this is > functionally the same, unless someone had variations in the spelling > of their real name over time, so either would work. Ah, yes, I somehow believed that not specifying the old name would just replace the email address. You’re right. >> Feels a bit like cheating, though...? > I wouldn't call it cheating. It is just an input for canonicalizing > contributors' identities, where there were changes in name or email > over time. It gives a more useful view to tools like 'git shortlog' > and 'git-dm' stats reports, such that all work over time will be > grouped together instead of split. Alright. Hanna
© 2016 - 2024 Red Hat, Inc.