[PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.

Warner Losh posted 49 patches 4 years, 4 months ago
Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>
There is a newer version of this series
[PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.
Posted by Warner Losh 4 years, 4 months ago
From: Warner Losh <imp@FreeBSD.org>

Signed-off-by: Warner Losh <imp@bsdimp.com>
---
 bsd-user/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bsd-user/main.c b/bsd-user/main.c
index 36852604f8..08f88d9668 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -405,8 +405,10 @@ int main(int argc, char **argv)
         accel_init_interfaces(ac);
         ac->init_machine(NULL);
     }
+
     cpu = cpu_create(cpu_type);
     env = cpu->env_ptr;
+    cpu_reset(cpu);
     thread_cpu = cpu;
 
     if (getenv("QEMU_STRACE")) {
-- 
2.32.0


Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.
Posted by Richard Henderson 4 years, 4 months ago
On 8/7/21 11:42 AM, Warner Losh wrote:
> From: Warner Losh<imp@FreeBSD.org>
> 
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/main.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Slightly amusing that the line was removed in patch 1, because it was ifdefed.


r~

Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.
Posted by Warner Losh 4 years, 4 months ago
On Tue, Aug 10, 2021 at 10:32 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 8/7/21 11:42 AM, Warner Losh wrote:
> > From: Warner Losh<imp@FreeBSD.org>
> >
> > Signed-off-by: Warner Losh<imp@bsdimp.com>
> > ---
> >   bsd-user/main.c | 2 ++
> >   1 file changed, 2 insertions(+)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> Slightly amusing that the line was removed in patch 1, because it was
> ifdefed.
>

Worth folding?

And good eye!

Warner
Re: [PATCH for 6.2 39/49] bsd-user: Need to reset CPU after creation.
Posted by Richard Henderson 4 years, 4 months ago
On 8/10/21 12:40 PM, Warner Losh wrote:
>     Slightly amusing that the line was removed in patch 1, because it was ifdefed.
> 
> Worth folding?

Might as well.


r~