[v1] bsd-user updates to run hello world

[PATCH for 6.2 35/49] bsd-user: remove error_init

Warner Losh posted 49 patches 4 years, 4 months ago

Diff against v1 v1 v2 v3
Download mbox

Maintainers: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>

There is a newer version of this series

[PATCH for 6.2 35/49] bsd-user: remove error_init

Posted by Warner Losh 4 years, 4 months ago

From: Warner Losh <imp@FreeBSD.org>

Error reporting isn't used, so gc it until it's used.

Signed-off-by: Warner Losh  <imp@bsdimp.com>
---
 bsd-user/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/bsd-user/main.c b/bsd-user/main.c
index b5527537b4..7e20430fb7 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -34,7 +34,6 @@
 #include "qapi/error.h"
 #include "qemu.h"
 #include "qemu/config-file.h"
-#include "qemu/error-report.h"
 #include "qemu/path.h"
 #include "qemu/help_option.h"
 #include "qemu/module.h"
@@ -223,7 +222,6 @@ int main(int argc, char **argv)
 
     save_proc_pathname(argv[0]);
 
-    error_init(argv[0]);
     module_call_init(MODULE_INIT_TRACE);
     qemu_init_cpu_list();
     module_call_init(MODULE_INIT_QOM);
-- 
2.32.0

Re: [PATCH for 6.2 35/49] bsd-user: remove error_init

Posted by Richard Henderson 4 years, 4 months ago

On 8/7/21 11:42 AM, Warner Losh wrote:
> From: Warner Losh <imp@FreeBSD.org>
> 
> Error reporting isn't used, so gc it until it's used.
> 
> Signed-off-by: Warner Losh  <imp@bsdimp.com>

That's not true.  At minimum, tcg/ uses Error during alloc_code_gen_buffer.


r~

> ---
>   bsd-user/main.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index b5527537b4..7e20430fb7 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -34,7 +34,6 @@
>   #include "qapi/error.h"
>   #include "qemu.h"
>   #include "qemu/config-file.h"
> -#include "qemu/error-report.h"
>   #include "qemu/path.h"
>   #include "qemu/help_option.h"
>   #include "qemu/module.h"
> @@ -223,7 +222,6 @@ int main(int argc, char **argv)
>   
>       save_proc_pathname(argv[0]);
>   
> -    error_init(argv[0]);
>       module_call_init(MODULE_INIT_TRACE);
>       qemu_init_cpu_list();
>       module_call_init(MODULE_INIT_QOM);
>

Re: [PATCH for 6.2 35/49] bsd-user: remove error_init

Posted by Warner Losh 4 years, 4 months ago

On Tue, Aug 10, 2021 at 9:07 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 8/7/21 11:42 AM, Warner Losh wrote:
> > From: Warner Losh <imp@FreeBSD.org>
> >
> > Error reporting isn't used, so gc it until it's used.
> >
> > Signed-off-by: Warner Losh  <imp@bsdimp.com>
>
> That's not true.  At minimum, tcg/ uses Error during alloc_code_gen_buffer.
>

I'm not sure how I overlooked that, so I'll just drop this patch. Thanks
for the
good eye.

Warner


> r~
>
> > ---
> >   bsd-user/main.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/bsd-user/main.c b/bsd-user/main.c
> > index b5527537b4..7e20430fb7 100644
> > --- a/bsd-user/main.c
> > +++ b/bsd-user/main.c
> > @@ -34,7 +34,6 @@
> >   #include "qapi/error.h"
> >   #include "qemu.h"
> >   #include "qemu/config-file.h"
> > -#include "qemu/error-report.h"
> >   #include "qemu/path.h"
> >   #include "qemu/help_option.h"
> >   #include "qemu/module.h"
> > @@ -223,7 +222,6 @@ int main(int argc, char **argv)
> >
> >       save_proc_pathname(argv[0]);
> >
> > -    error_init(argv[0]);
> >       module_call_init(MODULE_INIT_TRACE);
> >       qemu_init_cpu_list();
> >       module_call_init(MODULE_INIT_QOM);
> >
>
>