[PATCH] vhost-user: add missing space in error message

Alyssa Ross posted 1 patch 2 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210806143926.315725-1-hi@alyssa.is
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
hw/virtio/vhost-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] vhost-user: add missing space in error message
Posted by Alyssa Ross 2 years, 9 months ago
This would previously give error messages like

> Received unexpected msg type.Expected 0 received 1

Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 29ea2b4fce..ad9fc40271 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -429,7 +429,7 @@ static int process_message_reply(struct vhost_dev *dev,
     }
 
     if (msg_reply.hdr.request != msg->hdr.request) {
-        error_report("Received unexpected msg type."
+        error_report("Received unexpected msg type. "
                      "Expected %d received %d",
                      msg->hdr.request, msg_reply.hdr.request);
         return -1;

base-commit: bccabb3a5d60182645c7749e89f21a9ff307a9eb
-- 
2.32.0


Re: [PATCH] vhost-user: add missing space in error message
Posted by Laurent Vivier 2 years, 9 months ago
Le 06/08/2021 à 16:39, Alyssa Ross a écrit :
> This would previously give error messages like
> 
>> Received unexpected msg type.Expected 0 received 1
> 
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 29ea2b4fce..ad9fc40271 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -429,7 +429,7 @@ static int process_message_reply(struct vhost_dev *dev,
>      }
>  
>      if (msg_reply.hdr.request != msg->hdr.request) {
> -        error_report("Received unexpected msg type."
> +        error_report("Received unexpected msg type. "
>                       "Expected %d received %d",
>                       msg->hdr.request, msg_reply.hdr.request);
>          return -1;
> 
> base-commit: bccabb3a5d60182645c7749e89f21a9ff307a9eb
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>