qom: Fix broken OBJECT_CHECK usage

[PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

Posted by Eduardo Habkost 4 years, 6 months ago

The macro never worked and never will, because the
AcpiGedX86State type never existed.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
---
 include/hw/acpi/generic_event_device.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/acpi/generic_event_device.h b/include/hw/acpi/generic_event_device.h
index 6bed92e8fc5..d49217c445f 100644
--- a/include/hw/acpi/generic_event_device.h
+++ b/include/hw/acpi/generic_event_device.h
@@ -70,8 +70,6 @@
 OBJECT_DECLARE_SIMPLE_TYPE(AcpiGedState, ACPI_GED)
 
 #define TYPE_ACPI_GED_X86 "acpi-ged-x86"
-#define ACPI_GED_X86(obj) \
-    OBJECT_CHECK(AcpiGedX86State, (obj), TYPE_ACPI_GED_X86)
 
 #define ACPI_GED_EVT_SEL_OFFSET    0x0
 #define ACPI_GED_EVT_SEL_LEN       0x4
-- 
2.31.1

Re: [PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

Posted by Igor Mammedov 4 years, 6 months ago

On Thu,  5 Aug 2021 15:34:26 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:

> The macro never worked and never will, because the
> AcpiGedX86State type never existed.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
>  include/hw/acpi/generic_event_device.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/hw/acpi/generic_event_device.h b/include/hw/acpi/generic_event_device.h
> index 6bed92e8fc5..d49217c445f 100644
> --- a/include/hw/acpi/generic_event_device.h
> +++ b/include/hw/acpi/generic_event_device.h
> @@ -70,8 +70,6 @@
>  OBJECT_DECLARE_SIMPLE_TYPE(AcpiGedState, ACPI_GED)
>  
>  #define TYPE_ACPI_GED_X86 "acpi-ged-x86"
> -#define ACPI_GED_X86(obj) \
> -    OBJECT_CHECK(AcpiGedX86State, (obj), TYPE_ACPI_GED_X86)
>  
>  #define ACPI_GED_EVT_SEL_OFFSET    0x0
>  #define ACPI_GED_EVT_SEL_LEN       0x4

Re: [PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

Posted by Gerd Hoffmann 4 years, 6 months ago

On Thu, Aug 05, 2021 at 03:34:26PM -0400, Eduardo Habkost wrote:
> The macro never worked and never will, because the
> AcpiGedX86State type never existed.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

> -#define ACPI_GED_X86(obj) \
> -    OBJECT_CHECK(AcpiGedX86State, (obj), TYPE_ACPI_GED_X86)

Oops.  Leftover from an earlier patch revision where the struct did
actually exist.  Thanks for cleaning up.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

[PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro
[PATCH for-6.2 2/6] sbsa_gwdt: Delete broken SBSA_*CLASS macros
[PATCH for-6.2 3/6] s390-sclp-events-bus: Set instance_size
[PATCH for-6.2 4/6] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE
[PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro
[PATCH for-6.2 6/6] Use PCI_HOST_BRIDGE macro