[v1] s390x: skey related fixes, cleanups, and memory device preparations

[PATCH v1 06/12] s390x/mmu_helper: fixup mmu_translate() documentation

Posted by David Hildenbrand 4 years, 6 months ago

Looks like we forgot to adjust documentation of one parameter.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/mmu_helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 167f1b1455..ca25dadb5b 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -374,7 +374,8 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags)
  * @param asc    address space control (one of the PSW_ASC_* modes)
  * @param raddr  the translated address is stored to this pointer
  * @param flags  the PAGE_READ/WRITE/EXEC flags are stored to this pointer
- * @param exc    true = inject a program check if a fault occurred
+ * @param tec    the translation exception code if stored to this pointer if
+ *               there is an exception to raise
  * @return       0 = success, != 0, the exception to raise
  */
 int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
-- 
2.31.1

Re: [PATCH v1 06/12] s390x/mmu_helper: fixup mmu_translate() documentation

Posted by Thomas Huth 4 years, 6 months ago

On 05/08/2021 17.27, David Hildenbrand wrote:
> Looks like we forgot to adjust documentation of one parameter.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   target/s390x/mmu_helper.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index 167f1b1455..ca25dadb5b 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -374,7 +374,8 @@ static void mmu_handle_skey(target_ulong addr, int rw, int *flags)
>    * @param asc    address space control (one of the PSW_ASC_* modes)
>    * @param raddr  the translated address is stored to this pointer
>    * @param flags  the PAGE_READ/WRITE/EXEC flags are stored to this pointer
> - * @param exc    true = inject a program check if a fault occurred
> + * @param tec    the translation exception code if stored to this pointer if
> + *               there is an exception to raise
>    * @return       0 = success, != 0, the exception to raise
>    */
>   int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>