[v1] s390x: skey related fixes, cleanups, and memory device preparations

[PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

Posted by David Hildenbrand 4 years, 6 months ago

The access type is unused.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/mmu_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 0620b1803e..167f1b1455 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -125,7 +125,7 @@ static inline bool read_table_entry(CPUS390XState *env, hwaddr gaddr,
 
 static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr,
                               uint64_t asc, uint64_t asce, target_ulong *raddr,
-                              int *flags, int rw)
+                              int *flags)
 {
     const bool edat1 = (env->cregs[0] & CR0_EDAT) &&
                        s390_has_feat(S390_FEAT_EDAT);
@@ -428,7 +428,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
     }
 
     /* perform the DAT translation */
-    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags, rw);
+    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags);
     if (unlikely(r)) {
         return r;
     }
-- 
2.31.1

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

Posted by Thomas Huth 4 years, 6 months ago

On 05/08/2021 17.27, David Hildenbrand wrote:
> The access type is unused.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   target/s390x/mmu_helper.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index 0620b1803e..167f1b1455 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -125,7 +125,7 @@ static inline bool read_table_entry(CPUS390XState *env, hwaddr gaddr,
>   
>   static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr,
>                                 uint64_t asc, uint64_t asce, target_ulong *raddr,
> -                              int *flags, int rw)
> +                              int *flags)
>   {
>       const bool edat1 = (env->cregs[0] & CR0_EDAT) &&
>                          s390_has_feat(S390_FEAT_EDAT);
> @@ -428,7 +428,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
>       }
>   
>       /* perform the DAT translation */
> -    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags, rw);
> +    r = mmu_translate_asce(env, vaddr, asc, asce, raddr, flags);
>       if (unlikely(r)) {
>           return r;
>       }
> 

Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place")

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

Posted by David Hildenbrand 4 years, 6 months ago

On 06.08.21 09:30, Thomas Huth wrote:
> Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place")
> 
> Reviewed-by: Thomas Huth<thuth@redhat.com>

I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. 
At least in the kernel people will really complain if you do that 
(because it might result in backports of patches that are absolutely not 
worth backporting and makes actual bugfixes harder to track). But maybe 
QEMUs policy is different, so I can add it.

-- 
Thanks,

David / dhildenb

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

Posted by Thomas Huth 4 years, 6 months ago

On 06/08/2021 09.34, David Hildenbrand wrote:
> On 06.08.21 09:30, Thomas Huth wrote:
>> Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place")
>>
>> Reviewed-by: Thomas Huth<thuth@redhat.com>
> 
> I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At 
> least in the kernel people will really complain if you do that (because it 
> might result in backports of patches that are absolutely not worth 
> backporting and makes actual bugfixes harder to track). But maybe QEMUs 
> policy is different, so I can add it.

Fair point. Maybe simply mention the commit id in the patch description?

  Thomas

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

Posted by David Hildenbrand 4 years, 6 months ago

On 06.08.21 09:36, Thomas Huth wrote:
> On 06/08/2021 09.34, David Hildenbrand wrote:
>> On 06.08.21 09:30, Thomas Huth wrote:
>>> Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place")
>>>
>>> Reviewed-by: Thomas Huth<thuth@redhat.com>
>>
>> I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At
>> least in the kernel people will really complain if you do that (because it
>> might result in backports of patches that are absolutely not worth
>> backporting and makes actual bugfixes harder to track). But maybe QEMUs
>> policy is different, so I can add it.
> 
> Fair point. Maybe simply mention the commit id in the patch description?

Agreed, thanks!


-- 
Thanks,

David / dhildenb