[PATCH for-6.1 02/10] docs/devel/build-system.rst: Correct typo in example code

Peter Maydell posted 10 patches 4 years, 6 months ago
Maintainers: Laurent Vivier <lvivier@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Tyrone Ting <kfting@nuvoton.com>, Juan Quintela <quintela@redhat.com>, Mahmoud Mandour <ma.mandourr@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Havard Skinnemoen <hskinnemoen@google.com>, "Alex Bennée" <alex.bennee@linaro.org>, Radoslaw Biernacki <rad@semihalf.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Thomas Huth <thuth@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Cornelia Huck <cohuck@redhat.com>, Leif Lindholm <leif@nuviainc.com>, "Daniel P. Berrangé" <berrange@redhat.com>
[PATCH for-6.1 02/10] docs/devel/build-system.rst: Correct typo in example code
Posted by Peter Maydell 4 years, 6 months ago
One of the example meson.build fragments incorrectly quotes some
symbols as 'CONFIG_FOO`; the correct syntax here is 'CONFIG_FOO'.
(This isn't a rST formatting mistake because the example is displayed
literally; it's just the wrong kind of quote.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 docs/devel/build-system.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index ee660a998d0..3baec158f22 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -235,11 +235,11 @@ Target-independent emulator sourcesets:
   symbol::
 
     # Some targets have CONFIG_ACPI, some don't, so this is not enough
-    softmmu_ss.add(when: 'CONFIG_ACPI`, if_true: files('acpi.c'),
+    softmmu_ss.add(when: 'CONFIG_ACPI', if_true: files('acpi.c'),
                                         if_false: files('acpi-stub.c'))
 
     # This is required as well:
-    softmmu_ss.add(when: 'CONFIG_ALL`, if_true: files('acpi-stub.c'))
+    softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c'))
 
 Target-dependent emulator sourcesets:
   In the target-dependent set lives CPU emulation, some device emulation and
-- 
2.20.1


Re: [PATCH for-6.1 02/10] docs/devel/build-system.rst: Correct typo in example code
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago
On 7/26/21 4:23 PM, Peter Maydell wrote:
> One of the example meson.build fragments incorrectly quotes some
> symbols as 'CONFIG_FOO`; the correct syntax here is 'CONFIG_FOO'.
> (This isn't a rST formatting mistake because the example is displayed
> literally; it's just the wrong kind of quote.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  docs/devel/build-system.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>