[PULL 0/2] QAPI/QOM bugfix for QEMU 6.1

Paolo Bonzini posted 2 patches 2 years, 9 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210723100137.978910-1-pbonzini@redhat.com
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Michael Roth <michael.roth@amd.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>
include/qapi/forward-visitor.h    |  27 ++++
qapi/meson.build                  |   1 +
qapi/qapi-forward-visitor.c       | 331 ++++++++++++++++++++++++++++++++++++++
qom/object.c                      |   9 +-
tests/unit/meson.build            |   1 +
tests/unit/test-forward-visitor.c | 193 ++++++++++++++++++++++
6 files changed, 560 insertions(+), 2 deletions(-)
create mode 100644 include/qapi/forward-visitor.h
create mode 100644 qapi/qapi-forward-visitor.c
create mode 100644 tests/unit/test-forward-visitor.c
[PULL 0/2] QAPI/QOM bugfix for QEMU 6.1
Posted by Paolo Bonzini 2 years, 9 months ago
The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332:

  Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' into staging (2021-07-19 19:06:05 +0100)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream-qapi

for you to fetch changes up to 2f164a6c5e4a9e24a6d33fcd680f322dcf53a44e:

  qom: use correct field name when getting/setting alias properties (2021-07-23 11:57:15 +0200)

----------------------------------------------------------------
Fix for QOM alias properties (e.g. -M pflash0).

----------------------------------------------------------------
Paolo Bonzini (2):
      qapi: introduce forwarding visitor
      qom: use correct field name when getting/setting alias properties

 include/qapi/forward-visitor.h    |  27 ++++
 qapi/meson.build                  |   1 +
 qapi/qapi-forward-visitor.c       | 331 ++++++++++++++++++++++++++++++++++++++
 qom/object.c                      |   9 +-
 tests/unit/meson.build            |   1 +
 tests/unit/test-forward-visitor.c | 193 ++++++++++++++++++++++
 6 files changed, 560 insertions(+), 2 deletions(-)
 create mode 100644 include/qapi/forward-visitor.h
 create mode 100644 qapi/qapi-forward-visitor.c
 create mode 100644 tests/unit/test-forward-visitor.c
-- 
2.31.1


Re: [PULL 0/2] QAPI/QOM bugfix for QEMU 6.1
Posted by Peter Maydell 2 years, 9 months ago
On Fri, 23 Jul 2021 at 11:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332:
>
>   Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' into staging (2021-07-19 19:06:05 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream-qapi
>
> for you to fetch changes up to 2f164a6c5e4a9e24a6d33fcd680f322dcf53a44e:
>
>   qom: use correct field name when getting/setting alias properties (2021-07-23 11:57:15 +0200)
>
> ----------------------------------------------------------------
> Fix for QOM alias properties (e.g. -M pflash0).
>
> ----------------------------------------------------------------
> Paolo Bonzini (2):
>       qapi: introduce forwarding visitor
>       qom: use correct field name when getting/setting alias properties

Hi -- could you check whether this failed gitlab job for
build-oss-fuzz is valid or just another flaky CI issue, please?

https://gitlab.com/qemu-project/qemu/-/jobs/1448031475

The backtrace showing the leaks seems to be in the new test case
added in this pull, so my guess is it's real...

thanks
-- PMM

Re: [PULL 0/2] QAPI/QOM bugfix for QEMU 6.1
Posted by Paolo Bonzini 2 years, 9 months ago
On 23/07/21 17:52, Peter Maydell wrote:
> On Fri, 23 Jul 2021 at 11:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> The following changes since commit 143c2e0432859826c9e8d5b2baa307355f1a5332:
>>
>>    Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2021-07-19' into staging (2021-07-19 19:06:05 +0100)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/bonzini/qemu.git tags/for-upstream-qapi
>>
>> for you to fetch changes up to 2f164a6c5e4a9e24a6d33fcd680f322dcf53a44e:
>>
>>    qom: use correct field name when getting/setting alias properties (2021-07-23 11:57:15 +0200)
>>
>> ----------------------------------------------------------------
>> Fix for QOM alias properties (e.g. -M pflash0).
>>
>> ----------------------------------------------------------------
>> Paolo Bonzini (2):
>>        qapi: introduce forwarding visitor
>>        qom: use correct field name when getting/setting alias properties
> 
> Hi -- could you check whether this failed gitlab job for
> build-oss-fuzz is valid or just another flaky CI issue, please?
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/1448031475
> 
> The backtrace showing the leaks seems to be in the new test case
> added in this pull, so my guess is it's real...

Yeah, I was about to ask you not to pull this.

Paolo