plugins/cache: multicore cache modelling and minor tweaks

[PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks

Mahmoud Mandour posted 5 patches 2 years, 9 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210722065428.134608-1-ma.mandourr@gmail.com

Maintainers: Alexandre Iooss <erdnaxe@crans.org>, "Alex Bennée" <alex.bennee@linaro.org>, Mahmoud Mandour <ma.mandourr@gmail.com>

contrib/plugins/cache.c    | 165 ++++++++++++++++++++++++++++---------
docs/devel/tcg-plugins.rst |  13 +--
2 files changed, 132 insertions(+), 46 deletions(-)

Expand all Fold all

[PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks

Posted by Mahmoud Mandour 2 years, 9 months ago

Hello,

This series introduce some minor improvements/bug fixes in the cache
plugins and multicore cache modelling.

Multi-core cache modelling is handled such that for full-system
emulation, a private L1 cache is maintained to each core available to
the system. For multi-threaded userspace emulation, a static number of
cores is maintained for the overall system, and every memory access go
through one of these, even if the number of fired threads is more than
that number.

Also, raising the levels of warnings induced some warnings, this is
fixed in it's own patch.

Patches that still need review (other patches are already queued):
    1. plugins/cache: Supported multicore cache modelling
    2. docs/devel/tcg-plugins: added cores arg to cache plugin

v2 -> v3:
    1. Included the link of the patch solving the race.
    2. Fixed the title so that the series appears in Patchew.

v1 -> v2:
    1. Dropped the patch with mitigating the use-after-free bug since
    it's not needed anymore (fixed by Alex Bennée here
    <20210720232703.10650-1-alex.bennee@linaro.org> with patch name:
        tcg/plugins: implement a qemu_plugin_user_exit helper)
    2. Summed cache performance data as a post-processing step.
    3. Refactored appending core data to it's own function

Mahmoud Mandour (5):
  plugins/cache: Fixed a bug with destroying FIFO metadata
  plugins/cache: limited the scope of a mutex lock
  plugins/cache: Supported multicore cache modelling
  docs/devel/tcg-plugins: added cores arg to cache plugin
  plugins/cache: Fixed "function decl. is not a prototype" warnings

 contrib/plugins/cache.c    | 165 ++++++++++++++++++++++++++++---------
 docs/devel/tcg-plugins.rst |  13 +--
 2 files changed, 132 insertions(+), 46 deletions(-)

-- 
2.25.1

Re: [PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks

Posted by Alex Bennée 2 years, 9 months ago

Mahmoud Mandour <ma.mandourr@gmail.com> writes:

> Hello,
>
> This series introduce some minor improvements/bug fixes in the cache
> plugins and multicore cache modelling.
>
> Multi-core cache modelling is handled such that for full-system
> emulation, a private L1 cache is maintained to each core available to
> the system. For multi-threaded userspace emulation, a static number of
> cores is maintained for the overall system, and every memory access go
> through one of these, even if the number of fired threads is more than
> that number.
>
> Also, raising the levels of warnings induced some warnings, this is
> fixed in it's own patch.
>
> Patches that still need review (other patches are already queued):
>     1. plugins/cache: Supported multicore cache modelling
>     2. docs/devel/tcg-plugins: added cores arg to cache plugin

Could you re-base this onto the current master please? I skipped the
patches already merged but still couldn't get the series to cleanly
apply.

-- 
Alex Bennée