[PATCH] meson: fix dependencies for modinfo

Paolo Bonzini posted 1 patch 2 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210721165206.652325-1-pbonzini@redhat.com
meson.build | 1 +
1 file changed, 1 insertion(+)
[PATCH] meson: fix dependencies for modinfo
Posted by Paolo Bonzini 2 years, 9 months ago
modinfo runs the preprocessor and therefore needs all generated input files
to be there.  Add a "depends" clause.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index 8817706d08..18e6cb0a8c 100644
--- a/meson.build
+++ b/meson.build
@@ -2512,6 +2512,7 @@ foreach d, list : modules
                                        output: d + '-' + m + '.modinfo',
                                        input: module_ss.sources(),
                                        capture: true,
+                                       depends: genh,
                                        command: [modinfo_collect, '@INPUT@'])
       endif
     else
-- 
2.31.1


Re: [PATCH] meson: fix dependencies for modinfo
Posted by Daniel P. Berrangé 2 years, 9 months ago
On Wed, Jul 21, 2021 at 06:52:06PM +0200, Paolo Bonzini wrote:
> modinfo runs the preprocessor and therefore needs all generated input files
> to be there.  Add a "depends" clause.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|