usb: fix usb-host dependency check

[PATCH] usb: fix usb-host dependency check

Gerd Hoffmann posted 1 patch 4 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210721081718.301343-1-kraxel@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

hw/usb/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] usb: fix usb-host dependency check

Posted by Gerd Hoffmann 4 years, 6 months ago

Fixes: 627302afb2f8 ("usb: build usb-host as module")
Reported-by: Programmingkid <programmingkidx@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/meson.build b/hw/usb/meson.build
index 3ca61279374d..de853d780dd8 100644
--- a/hw/usb/meson.build
+++ b/hw/usb/meson.build
@@ -72,7 +72,7 @@ if usbredir.found()
 endif
 
 # usb pass-through
-if config_host.has_key('CONFIG_USB_LIBUSB')
+if libusb.found()
   usbhost_ss = ss.source_set()
   usbhost_ss.add(when: ['CONFIG_USB', libusb],
                  if_true: files('host-libusb.c'))
-- 
2.31.1

Re: [PATCH] usb: fix usb-host dependency check

Posted by Paolo Bonzini 4 years, 6 months ago

On 21/07/21 10:17, Gerd Hoffmann wrote:
> Fixes: 627302afb2f8 ("usb: build usb-host as module")
> Reported-by: Programmingkid <programmingkidx@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   hw/usb/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/meson.build b/hw/usb/meson.build
> index 3ca61279374d..de853d780dd8 100644
> --- a/hw/usb/meson.build
> +++ b/hw/usb/meson.build
> @@ -72,7 +72,7 @@ if usbredir.found()
>   endif
>   
>   # usb pass-through
> -if config_host.has_key('CONFIG_USB_LIBUSB')
> +if libusb.found()
>     usbhost_ss = ss.source_set()
>     usbhost_ss.add(when: ['CONFIG_USB', libusb],
>                    if_true: files('host-libusb.c'))
> 

Actually

Fixes: 90540f3289 ("configure, meson: convert libusb detection to 
meson", 2021-06-25)

Sorry about that.

Paolo

Re: [PATCH] usb: fix usb-host dependency check

Posted by Philippe Mathieu-Daudé 4 years, 6 months ago

On 7/21/21 10:17 AM, Gerd Hoffmann wrote:
> Fixes: 627302afb2f8 ("usb: build usb-host as module")
> Reported-by: Programmingkid <programmingkidx@gmail.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>