On Tue, 20 Jul 2021, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Looking at the MV64340 model source, there is a dependency on the
Small typo, it's MV64361 but maybe not a big problem if it's too late to
fix up the commit message. Sorry I did not notice earlier.
Regards,
BALATON Zoltan
> 8259 interrupt controller:
>
> 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG:
> 524 /* FIXME: Should this be sent via the PCI bus somehow? */
> 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) {
> 526 ret = pic_read_irq(isa_pic);
> 527 }
> 528 break;
>
> Add it to Kconfig to avoid the following build failure:
>
> /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361_read':
> hw/pci-host/mv64361.c:526: undefined reference to `isa_pic'
> /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_irq'
>
> Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC system controller")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Acked-by: David Gibson <david@gibson.dropbear.id.au>
> Message-Id: <20210515173716.358295-10-philmd@redhat.com>
> ---
> hw/pci-host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index 84494400b86..2b5f7d58cc5 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -76,3 +76,4 @@ config SH_PCI
> config MV64361
> bool
> select PCI
> + select I8259
>