[PATCH 00/16] Various error handling fixes and cleanups

Markus Armbruster posted 16 patches 2 years, 9 months ago
Failed in applying to current master (apply log)
backends/tpm/tpm_emulator.c |  3 +--
hw/display/qxl.c            |  8 ++++----
hw/i386/microvm.c           |  5 -----
hw/ppc/spapr_events.c       | 20 ++++++++++----------
hw/remote/mpqemu-link.c     |  3 ---
hw/remote/proxy.c           | 10 +++++++++-
hw/s390x/ipl.c              |  6 +-----
hw/scsi/vhost-scsi.c        |  4 ++--
hw/vfio/migration.c         |  6 ++----
hw/virtio/vhost-user.c      |  8 ++++++++
hw/virtio/vhost.c           | 16 +++-------------
migration/migration.c       | 34 ++++++++++------------------------
qemu-img.c                  |  6 +-----
qemu-io.c                   |  6 +-----
qemu-nbd.c                  |  5 +----
qga/commands-posix-ssh.c    | 17 -----------------
qga/commands-win32.c        |  1 -
scsi/qemu-pr-helper.c       | 11 +++--------
softmmu/vl.c                | 19 +++++++------------
target/i386/kvm/kvm.c       |  9 +++------
target/i386/nvmm/nvmm-all.c |  4 +---
target/i386/sev.c           |  8 +-------
target/i386/whpx/whpx-all.c |  4 +---
ui/console.c                |  7 ++-----
ui/spice-core.c             |  7 +------
25 files changed, 72 insertions(+), 155 deletions(-)
[PATCH 00/16] Various error handling fixes and cleanups
Posted by Markus Armbruster 2 years, 9 months ago
I doubt the fixes are 6.1 material at this late stage.  If you
disagree, let me know.

Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Aravinda Prasad <arawinda.p@gmail.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Cc: Ganesh Goudar <ganeshgr@linux.ibm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jagannathan Raman <jag.raman@oracle.com>
Cc: John G Johnson <john.g.johnson@oracle.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: Kamil Rytarowski <kamil@netbsd.org>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Reinoud Zandijk <reinoud@netbsd.org>
Cc: Sergio Lopez <slp@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
Cc: Thomas Huth <thuth@redhat.com>

Markus Armbruster (16):
  error: Use error_fatal to simplify obvious fatal errors (again)
  spapr: Plug memory leak when we can't add a migration blocker
  spapr: Explain purpose of ->fwnmi_migration_blocker more clearly
  multi-process: Fix pci_proxy_dev_realize() error handling
  vhost-scsi: Plug memory leak on migrate_add_blocker() failure
  i386: Never free migration blocker objects instead of sometimes
  vfio: Avoid error_propagate() after migrate_add_blocker()
  whpx nvmm: Drop useless migrate_del_blocker()
  migration: Unify failure check for migrate_add_blocker()
  migration: Handle migration_incoming_setup() errors consistently
  microvm: Drop dead error handling in microvm_machine_state_init()
  vhost: Clean up how VhostOpts method vhost_get_config() fails
  vhost: Clean up how VhostOpts method vhost_backend_init() fails
  Remove superfluous ERRP_GUARD()
  vl: Clean up -smp error handling
  vl: Don't continue after -smp help.

 backends/tpm/tpm_emulator.c |  3 +--
 hw/display/qxl.c            |  8 ++++----
 hw/i386/microvm.c           |  5 -----
 hw/ppc/spapr_events.c       | 20 ++++++++++----------
 hw/remote/mpqemu-link.c     |  3 ---
 hw/remote/proxy.c           | 10 +++++++++-
 hw/s390x/ipl.c              |  6 +-----
 hw/scsi/vhost-scsi.c        |  4 ++--
 hw/vfio/migration.c         |  6 ++----
 hw/virtio/vhost-user.c      |  8 ++++++++
 hw/virtio/vhost.c           | 16 +++-------------
 migration/migration.c       | 34 ++++++++++------------------------
 qemu-img.c                  |  6 +-----
 qemu-io.c                   |  6 +-----
 qemu-nbd.c                  |  5 +----
 qga/commands-posix-ssh.c    | 17 -----------------
 qga/commands-win32.c        |  1 -
 scsi/qemu-pr-helper.c       | 11 +++--------
 softmmu/vl.c                | 19 +++++++------------
 target/i386/kvm/kvm.c       |  9 +++------
 target/i386/nvmm/nvmm-all.c |  4 +---
 target/i386/sev.c           |  8 +-------
 target/i386/whpx/whpx-all.c |  4 +---
 ui/console.c                |  7 ++-----
 ui/spice-core.c             |  7 +------
 25 files changed, 72 insertions(+), 155 deletions(-)

-- 
2.31.1


Re: [PATCH 00/16] Various error handling fixes and cleanups
Posted by Michael S. Tsirkin 2 years, 9 months ago
On Tue, Jul 20, 2021 at 02:53:52PM +0200, Markus Armbruster wrote:
> I doubt the fixes are 6.1 material at this late stage.  If you
> disagree, let me know.
> 
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Aravinda Prasad <arawinda.p@gmail.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Cc: Ganesh Goudar <ganeshgr@linux.ibm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jagannathan Raman <jag.raman@oracle.com>
> Cc: John G Johnson <john.g.johnson@oracle.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Kamil Rytarowski <kamil@netbsd.org>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Reinoud Zandijk <reinoud@netbsd.org>
> Cc: Sergio Lopez <slp@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
> Cc: Thomas Huth <thuth@redhat.com>


Acked-by: Michael S. Tsirkin <mst@redhat.com>

agree it's not 6.1 material

> Markus Armbruster (16):
>   error: Use error_fatal to simplify obvious fatal errors (again)
>   spapr: Plug memory leak when we can't add a migration blocker
>   spapr: Explain purpose of ->fwnmi_migration_blocker more clearly
>   multi-process: Fix pci_proxy_dev_realize() error handling
>   vhost-scsi: Plug memory leak on migrate_add_blocker() failure
>   i386: Never free migration blocker objects instead of sometimes
>   vfio: Avoid error_propagate() after migrate_add_blocker()
>   whpx nvmm: Drop useless migrate_del_blocker()
>   migration: Unify failure check for migrate_add_blocker()
>   migration: Handle migration_incoming_setup() errors consistently
>   microvm: Drop dead error handling in microvm_machine_state_init()
>   vhost: Clean up how VhostOpts method vhost_get_config() fails
>   vhost: Clean up how VhostOpts method vhost_backend_init() fails
>   Remove superfluous ERRP_GUARD()
>   vl: Clean up -smp error handling
>   vl: Don't continue after -smp help.
> 
>  backends/tpm/tpm_emulator.c |  3 +--
>  hw/display/qxl.c            |  8 ++++----
>  hw/i386/microvm.c           |  5 -----
>  hw/ppc/spapr_events.c       | 20 ++++++++++----------
>  hw/remote/mpqemu-link.c     |  3 ---
>  hw/remote/proxy.c           | 10 +++++++++-
>  hw/s390x/ipl.c              |  6 +-----
>  hw/scsi/vhost-scsi.c        |  4 ++--
>  hw/vfio/migration.c         |  6 ++----
>  hw/virtio/vhost-user.c      |  8 ++++++++
>  hw/virtio/vhost.c           | 16 +++-------------
>  migration/migration.c       | 34 ++++++++++------------------------
>  qemu-img.c                  |  6 +-----
>  qemu-io.c                   |  6 +-----
>  qemu-nbd.c                  |  5 +----
>  qga/commands-posix-ssh.c    | 17 -----------------
>  qga/commands-win32.c        |  1 -
>  scsi/qemu-pr-helper.c       | 11 +++--------
>  softmmu/vl.c                | 19 +++++++------------
>  target/i386/kvm/kvm.c       |  9 +++------
>  target/i386/nvmm/nvmm-all.c |  4 +---
>  target/i386/sev.c           |  8 +-------
>  target/i386/whpx/whpx-all.c |  4 +---
>  ui/console.c                |  7 ++-----
>  ui/spice-core.c             |  7 +------
>  25 files changed, 72 insertions(+), 155 deletions(-)
> 
> -- 
> 2.31.1


Re: [PATCH 00/16] Various error handling fixes and cleanups
Posted by Markus Armbruster 2 years, 9 months ago
Markus Armbruster <armbru@redhat.com> writes:

> I doubt the fixes are 6.1 material at this late stage.  If you
> disagree, let me know.

PATCH 16 has become commit 3e61a13af3.  Remainder queued for 6.2;
additional review is welcome all the same.

Thanks, guys!