[PATCH 03/12] ui/gtk-clipboard: use existing macros

marcandre.lureau@redhat.com posted 12 patches 4 years, 6 months ago
There is a newer version of this series
[PATCH 03/12] ui/gtk-clipboard: use existing macros
Posted by marcandre.lureau@redhat.com 4 years, 6 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Rather than hardcoding strings

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 ui/gtk-clipboard.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c
index bff28d2030..5e817ae55c 100644
--- a/ui/gtk-clipboard.c
+++ b/ui/gtk-clipboard.c
@@ -177,11 +177,11 @@ void gd_clipboard_init(GtkDisplayState *gd)
     qemu_clipboard_peer_register(&gd->cbpeer);
 
     gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD] =
-        gtk_clipboard_get(gdk_atom_intern("CLIPBOARD", FALSE));
+        gtk_clipboard_get(GDK_SELECTION_CLIPBOARD);
     gd->gtkcb[QEMU_CLIPBOARD_SELECTION_PRIMARY] =
-        gtk_clipboard_get(gdk_atom_intern("PRIMARY", FALSE));
+        gtk_clipboard_get(GDK_SELECTION_PRIMARY);
     gd->gtkcb[QEMU_CLIPBOARD_SELECTION_SECONDARY] =
-        gtk_clipboard_get(gdk_atom_intern("SECONDARY", FALSE));
+        gtk_clipboard_get(GDK_SELECTION_SECONDARY);
 
     g_signal_connect(gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD],
                      "owner-change", G_CALLBACK(gd_owner_change), gd);
-- 
2.32.0.93.g670b81a890


Re: [PATCH 03/12] ui/gtk-clipboard: use existing macros
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago
On 7/19/21 9:26 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Rather than hardcoding strings

Why not write a full sentence? It is only 3 words saved, and
we could directly understand the comment without having to
look at the subject.

> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/gtk-clipboard.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c
> index bff28d2030..5e817ae55c 100644
> --- a/ui/gtk-clipboard.c
> +++ b/ui/gtk-clipboard.c
> @@ -177,11 +177,11 @@ void gd_clipboard_init(GtkDisplayState *gd)
>      qemu_clipboard_peer_register(&gd->cbpeer);
>  
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD] =
> -        gtk_clipboard_get(gdk_atom_intern("CLIPBOARD", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_CLIPBOARD);
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_PRIMARY] =
> -        gtk_clipboard_get(gdk_atom_intern("PRIMARY", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_PRIMARY);
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_SECONDARY] =
> -        gtk_clipboard_get(gdk_atom_intern("SECONDARY", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_SECONDARY);
>  
>      g_signal_connect(gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD],
>                       "owner-change", G_CALLBACK(gd_owner_change), gd);
>