We recently bumped our requirement for Clang to at least version 6.0.
And according to:
https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html
Clang v6.0 supports the alloc_size attribute. Thus we can drop this
check in the configure script now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/configure b/configure
index a0a32c427c..eee1356814 100755
--- a/configure
+++ b/configure
@@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then
"build target"
fi
-# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
-cat > $TMPC << EOF
-#include <glib.h>
-int main(void) { return 0; }
-EOF
-if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then
- if cc_has_warning_flag "-Wno-unknown-attributes"; then
- glib_cflags="-Wno-unknown-attributes $glib_cflags"
- CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS"
- fi
-fi
-
# Silence clang warnings triggered by glib < 2.57.2
cat > $TMPC << EOF
#include <glib.h>
--
2.27.0
On Wed, Jul 14, 2021 at 09:28:55AM +0200, Thomas Huth wrote: > We recently bumped our requirement for Clang to at least version 6.0. > And according to: > > https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html > > Clang v6.0 supports the alloc_size attribute. Thus we can drop this > check in the configure script now. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > configure | 12 ------------ > 1 file changed, 12 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 14/07/21 09:28, Thomas Huth wrote: > We recently bumped our requirement for Clang to at least version 6.0. > And according to: > > https://releases.llvm.org/6.0.0/tools/clang/docs/AttributeReference.html > > Clang v6.0 supports the alloc_size attribute. Thus we can drop this > check in the configure script now. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > configure | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/configure b/configure > index a0a32c427c..eee1356814 100755 > --- a/configure > +++ b/configure > @@ -3184,18 +3184,6 @@ if ! compile_prog "$glib_cflags" "$glib_libs" ; then > "build target" > fi > > -# Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage > -cat > $TMPC << EOF > -#include <glib.h> > -int main(void) { return 0; } > -EOF > -if ! compile_prog "$glib_cflags -Werror" "$glib_libs" ; then > - if cc_has_warning_flag "-Wno-unknown-attributes"; then > - glib_cflags="-Wno-unknown-attributes $glib_cflags" > - CONFIGURE_CFLAGS="-Wno-unknown-attributes $CONFIGURE_CFLAGS" > - fi > -fi > - > # Silence clang warnings triggered by glib < 2.57.2 > cat > $TMPC << EOF > #include <glib.h> > Queued, thanks. Paolo
© 2016 - 2024 Red Hat, Inc.