The goal here was to address Brad's report for clang vs ppc32.

Somewhere in between here and there I forgot about the ppc32 part,
needed a newer clang for gcc135, accidentally built master instead
of the clang-12 release branch, fixed a bunch of buggy looking
things, and only then remembered I was building ppc64 and wasn't
going to test what I thought I would.

So: Brad, could you double-check this fixes your problem?

Others: Only patch 7 obviously should have been using the
variable indicated as unused.  But please double-check.


r~


Cc: Alex Bennée <alex.bennee@linaro.org>
Cc: Brad Smith <brad@comstyle.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: Eric Blake <eblake@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Greg Kurz <groug@kaod.org>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-block@nongnu.org
Cc: qemu-ppc@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>


Richard Henderson (11):
  nbd/server: Remove unused variable
  accel/tcg: Remove unused variable in cpu_exec
  util/selfmap: Discard mapping on error
  net/checksum: Remove unused variable in net_checksum_add_iov
  hw/audio/adlib: Remove unused variable in adlib_callback
  hw/ppc/spapr_events: Remove unused variable from check_exception
  hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
  linux-user/syscall: Remove unused variable from execve
  tests/unit: Remove unused variable from test_io
  tcg/ppc: Replace TCG_TARGET_CALL_DARWIN with _CALL_DARWIN
  tcg/ppc: Ensure _CALL_SYSV is set for 32-bit ELF

 accel/tcg/cpu-exec.c     |  3 ---
 hw/audio/adlib.c         |  3 +--
 hw/pci-host/pnv_phb4.c   |  2 +-
 hw/ppc/spapr_events.c    |  5 -----
 linux-user/syscall.c     |  3 ---
 nbd/server.c             |  4 ----
 net/checksum.c           |  4 +---
 tests/unit/test-iov.c    |  5 +----
 util/selfmap.c           | 28 ++++++++++++++++------------
 tcg/ppc/tcg-target.c.inc | 25 ++++++++++++++++++++-----
 10 files changed, 40 insertions(+), 42 deletions(-)

-- 
2.25.1

On 7/12/2021 5:55 PM, Richard Henderson wrote:
> The goal here was to address Brad's report for clang vs ppc32.
>
> Somewhere in between here and there I forgot about the ppc32 part,
> needed a newer clang for gcc135, accidentally built master instead
> of the clang-12 release branch, fixed a bunch of buggy looking
> things, and only then remembered I was building ppc64 and wasn't
> going to test what I thought I would.
>
> So: Brad, could you double-check this fixes your problem?

Yes, this does. Thank you.

> Others: Only patch 7 obviously should have been using the
> variable indicated as unused.  But please double-check.
>
>
> r~
>
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Cc: Brad Smith <brad@comstyle.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: qemu-block@nongnu.org
> Cc: qemu-ppc@nongnu.org
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
>
> Richard Henderson (11):
>    nbd/server: Remove unused variable
>    accel/tcg: Remove unused variable in cpu_exec
>    util/selfmap: Discard mapping on error
>    net/checksum: Remove unused variable in net_checksum_add_iov
>    hw/audio/adlib: Remove unused variable in adlib_callback
>    hw/ppc/spapr_events: Remove unused variable from check_exception
>    hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
>    linux-user/syscall: Remove unused variable from execve
>    tests/unit: Remove unused variable from test_io
>    tcg/ppc: Replace TCG_TARGET_CALL_DARWIN with _CALL_DARWIN
>    tcg/ppc: Ensure _CALL_SYSV is set for 32-bit ELF
>
>   accel/tcg/cpu-exec.c     |  3 ---
>   hw/audio/adlib.c         |  3 +--
>   hw/pci-host/pnv_phb4.c   |  2 +-
>   hw/ppc/spapr_events.c    |  5 -----
>   linux-user/syscall.c     |  3 ---
>   nbd/server.c             |  4 ----
>   net/checksum.c           |  4 +---
>   tests/unit/test-iov.c    |  5 +----
>   util/selfmap.c           | 28 ++++++++++++++++------------
>   tcg/ppc/tcg-target.c.inc | 25 ++++++++++++++++++++-----
>   10 files changed, 40 insertions(+), 42 deletions(-)
>