[PULL 0/6] hw/nvme patches

Klaus Jensen posted 6 patches 2 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210711202736.591334-1-its@irrelevant.dk
Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>
hw/nvme/nvme.h          | 18 ++++++------
hw/nvme/ctrl.c          | 27 ++++++++++++++----
hw/nvme/ns.c            | 55 ++++++++++++++++++++++++-------------
hw/nvme/subsys.c        |  9 ++++++
tests/qtest/nvme-test.c | 61 ++++++++++++++++++++++++++++++++++++++++-
hw/nvme/trace-events    |  1 +
6 files changed, 137 insertions(+), 34 deletions(-)
[PULL 0/6] hw/nvme patches
Posted by Klaus Jensen 2 years, 9 months ago
From: Klaus Jensen <k.jensen@samsung.com>

Hi Pater,

The following changes since commit 9516034d05a8c71ef157a59f525e4c4f7ed79827:

  Merge remote-tracking branch 'remotes/cminyard/tags/for-qemu-6.1-2' into staging (2021-07-11 14:32:49 +0100)

are available in the Git repository at:

  git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request

for you to fetch changes up to 9cc1a34ec4fe7e89e44e460dcf50159e40962e59:

  hw/nvme: fix controller hot unplugging (2021-07-11 21:50:22 +0200)

----------------------------------------------------------------
hw/nvme patches

* new PMR test (Gollu Appalanaidu)
* pmr/sgl mapping fix (Padmakar Kalghatgi)
* hotplug fixes (me)

----------------------------------------------------------------

Gollu Appalanaidu (1):
  tests/qtest/nvme-test: add persistent memory region test

Klaus Jensen (4):
  hw/nvme: remove NvmeCtrl parameter from ns setup/check functions
  hw/nvme: mark nvme-subsys non-hotpluggable
  hw/nvme: unregister controller with subsystem at exit
  hw/nvme: fix controller hot unplugging

Padmakar Kalghatgi (1):
  hw/nvme: error handling for too many mappings

 hw/nvme/nvme.h          | 18 ++++++------
 hw/nvme/ctrl.c          | 27 ++++++++++++++----
 hw/nvme/ns.c            | 55 ++++++++++++++++++++++++-------------
 hw/nvme/subsys.c        |  9 ++++++
 tests/qtest/nvme-test.c | 61 ++++++++++++++++++++++++++++++++++++++++-
 hw/nvme/trace-events    |  1 +
 6 files changed, 137 insertions(+), 34 deletions(-)

-- 
2.32.0


Re: [PULL 0/6] hw/nvme patches
Posted by Peter Maydell 2 years, 9 months ago
On Sun, 11 Jul 2021 at 21:27, Klaus Jensen <its@irrelevant.dk> wrote:
>
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Hi Pater,
>
> The following changes since commit 9516034d05a8c71ef157a59f525e4c4f7ed79827:
>
>   Merge remote-tracking branch 'remotes/cminyard/tags/for-qemu-6.1-2' into staging (2021-07-11 14:32:49 +0100)
>
> are available in the Git repository at:
>
>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
>
> for you to fetch changes up to 9cc1a34ec4fe7e89e44e460dcf50159e40962e59:
>
>   hw/nvme: fix controller hot unplugging (2021-07-11 21:50:22 +0200)
>
> ----------------------------------------------------------------
> hw/nvme patches
>
> * new PMR test (Gollu Appalanaidu)
> * pmr/sgl mapping fix (Padmakar Kalghatgi)
> * hotplug fixes (me)
>
> ----------------------------------------------------------------
>
> Gollu Appalanaidu (1):
>   tests/qtest/nvme-test: add persistent memory region test
>
> Klaus Jensen (4):
>   hw/nvme: remove NvmeCtrl parameter from ns setup/check functions
>   hw/nvme: mark nvme-subsys non-hotpluggable
>   hw/nvme: unregister controller with subsystem at exit
>   hw/nvme: fix controller hot unplugging
>
> Padmakar Kalghatgi (1):
>   hw/nvme: error handling for too many mappings

Hi; this failed an assertion on two of the travis CI jobs and
then got timed-out for not producing any more output:

https://app.travis-ci.com/gitlab/qemu-project/qemu/jobs/523720897
https://app.travis-ci.com/gitlab/qemu-project/qemu/jobs/523720898

ERROR:../tests/qtest/nvme-test.c:89:nvmetest_pmr_reg_test: assertion
failed (NVME_PMRCAP_RDS(pmrcap) == 0x1): (0 == 1)

ERROR qtest-ppc64/qos-test - Bail out!
ERROR:../tests/qtest/nvme-test.c:89:nvmetest_pmr_reg_test: assertion
failed (NVME_PMRCAP_RDS(pmrcap) == 0x1): (0 == 1)

No output has been received in the last 10m0s, this potentially
indicates a stalled build or something wrong with the build itself.



These jobs both run on s390, and my ppc64be and s390 hosts
both hung during "make check", so I think you have an
issue on big-endian hosts somewhere.

thanks
-- PMM

Re: [PULL 0/6] hw/nvme patches
Posted by Klaus Jensen 2 years, 9 months ago
On Jul 12 15:51, Peter Maydell wrote:
> On Sun, 11 Jul 2021 at 21:27, Klaus Jensen <its@irrelevant.dk> wrote:
> >
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Hi Pater,
> >
> > The following changes since commit 9516034d05a8c71ef157a59f525e4c4f7ed79827:
> >
> >   Merge remote-tracking branch 'remotes/cminyard/tags/for-qemu-6.1-2' into staging (2021-07-11 14:32:49 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
> >
> > for you to fetch changes up to 9cc1a34ec4fe7e89e44e460dcf50159e40962e59:
> >
> >   hw/nvme: fix controller hot unplugging (2021-07-11 21:50:22 +0200)
> >
> > ----------------------------------------------------------------
> > hw/nvme patches
> >
> > * new PMR test (Gollu Appalanaidu)
> > * pmr/sgl mapping fix (Padmakar Kalghatgi)
> > * hotplug fixes (me)
> >
> > ----------------------------------------------------------------
> >
> > Gollu Appalanaidu (1):
> >   tests/qtest/nvme-test: add persistent memory region test
> >
> > Klaus Jensen (4):
> >   hw/nvme: remove NvmeCtrl parameter from ns setup/check functions
> >   hw/nvme: mark nvme-subsys non-hotpluggable
> >   hw/nvme: unregister controller with subsystem at exit
> >   hw/nvme: fix controller hot unplugging
> >
> > Padmakar Kalghatgi (1):
> >   hw/nvme: error handling for too many mappings
> 
> Hi; this failed an assertion on two of the travis CI jobs and
> then got timed-out for not producing any more output:
> 
> https://app.travis-ci.com/gitlab/qemu-project/qemu/jobs/523720897
> https://app.travis-ci.com/gitlab/qemu-project/qemu/jobs/523720898
> 
> ERROR:../tests/qtest/nvme-test.c:89:nvmetest_pmr_reg_test: assertion
> failed (NVME_PMRCAP_RDS(pmrcap) == 0x1): (0 == 1)
> 
> ERROR qtest-ppc64/qos-test - Bail out!
> ERROR:../tests/qtest/nvme-test.c:89:nvmetest_pmr_reg_test: assertion
> failed (NVME_PMRCAP_RDS(pmrcap) == 0x1): (0 == 1)
> 
> No output has been received in the last 10m0s, this potentially
> indicates a stalled build or something wrong with the build itself.
> 
> 
> 
> These jobs both run on s390, and my ppc64be and s390 hosts
> both hung during "make check", so I think you have an
> issue on big-endian hosts somewhere.
> 

Thanks Peter,

I'll look into it!