[v4] dp8393x: fixes and improvements

[PATCH v4 0/5] dp8393x: fixes and improvements

Posted by Philippe Mathieu-Daudé 2 years, 9 months ago

Hi Mark,

This should be the last respin.

Since v3:
- dropped worrying patches
- squashed migration patch
- added tags

Patch #3 (dp8393x: Store CAM registers as 16-bit) still
misses your S-o-b tag.

Based-on mips-next.

Mark Cave-Ayland (1):
  dp8393x: don't force 32-bit register access

Philippe Mathieu-Daudé (4):
  dp8393x: Replace address_space_rw(is_write=1) by address_space_write()
  dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition
  dp8393x: Store CAM registers as 16-bit
  dp8393x: Rewrite dp8393x_get() / dp8393x_put()

 hw/net/dp8393x.c | 206 ++++++++++++++++++++---------------------------
 1 file changed, 87 insertions(+), 119 deletions(-)

-- 
2.31.1

Re: [PATCH v4 0/5] dp8393x: fixes and improvements

Posted by Mark Cave-Ayland 2 years, 9 months ago

On 11/07/2021 11:36, Philippe Mathieu-Daudé wrote:

> Hi Mark,
> 
> This should be the last respin.
> 
> Since v3:
> - dropped worrying patches
> - squashed migration patch
> - added tags
> 
> Patch #3 (dp8393x: Store CAM registers as 16-bit) still
> misses your S-o-b tag.
> 
> Based-on mips-next.
> 
> Mark Cave-Ayland (1):
>    dp8393x: don't force 32-bit register access
> 
> Philippe Mathieu-Daudé (4):
>    dp8393x: Replace address_space_rw(is_write=1) by address_space_write()
>    dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition
>    dp8393x: Store CAM registers as 16-bit
>    dp8393x: Rewrite dp8393x_get() / dp8393x_put()
> 
>   hw/net/dp8393x.c | 206 ++++++++++++++++++++---------------------------
>   1 file changed, 87 insertions(+), 119 deletions(-)

Thanks Phil. A small typo in the subject line of patch 2, but otherwise this series 
passes my local tests (assuming "dp8393x: fix CAM descriptor entry index" is already 
applied to mips-next).

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [PATCH v4 0/5] dp8393x: fixes and improvements

Posted by Philippe Mathieu-Daudé 2 years, 9 months ago

On 7/11/21 12:36 PM, Philippe Mathieu-Daudé wrote:
> Hi Mark,
> 
> This should be the last respin.
> 
> Since v3:
> - dropped worrying patches
> - squashed migration patch
> - added tags
> 
> Patch #3 (dp8393x: Store CAM registers as 16-bit) still
> misses your S-o-b tag.
> 
> Based-on mips-next.
> 
> Mark Cave-Ayland (1):
>   dp8393x: don't force 32-bit register access
> 
> Philippe Mathieu-Daudé (4):
>   dp8393x: Replace address_space_rw(is_write=1) by address_space_write()
>   dp8393x: Replace 0x40 magic value by SONIC_REG16_COUNT definition
>   dp8393x: Store CAM registers as 16-bit
>   dp8393x: Rewrite dp8393x_get() / dp8393x_put()

Series applied to mips-next.