target/arm: Fix offsets for TTBCR (#187)

[PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)

Richard Henderson posted 1 patch 4 years, 7 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210709230621.938821-1-richard.henderson@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>

target/arm/helper.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)

Posted by Richard Henderson 4 years, 7 months ago

This one patch fixes boot_linux_console test_arm_virt.

It does not fix all of the failures.  The next one on the
list is test_arm_emcraft_sf2, where the cpu boots fine but
the net device doesn't work correctly.


r~


Richard Henderson (1):
  target/arm: Fix offsets for TTBCR

 target/arm/helper.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.25.1

Re: [PATCH 0/1] target/arm: Fix offsets for TTBCR (#187)

Posted by Peter Maydell 4 years, 7 months ago

On Sat, 10 Jul 2021 at 00:07, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This one patch fixes boot_linux_console test_arm_virt.
>
> It does not fix all of the failures.  The next one on the
> list is test_arm_emcraft_sf2, where the cpu boots fine but
> the net device doesn't work correctly.

Applied to target-arm.next, thanks.

I'm not sure the TCR struct's precalculation of mask and base_mask
is still earning its keep as an optimization. We only use them in
get_level1_table_address() which is old-style v5/v6 page tables only,
and all it's saving us is a bitfield extract and some shifts, which
is peanuts compared to everything else we do in a page table walk.
Perhaps (not for 6.1) we could drop it entirely.

-- PMM