1. Patchew
  2. QEMU
  3. View series

[PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

Jonathan Albrecht posted 2 patches 2 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210709160459.4962-1-jonathan.albrecht@linux.vnet.ibm.com
Maintainers: Laurent Vivier <laurent@vivier.eu>, Richard Henderson <richard.henderson@linaro.org>, Cornelia Huck <cohuck@redhat.com>, David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>
linux-user/s390x/cpu_loop.c     |  54 ++++++++++-------
tests/tcg/s390x/Makefile.target |   1 +
tests/tcg/s390x/trap.c          | 102 ++++++++++++++++++++++++++++++++
3 files changed, 137 insertions(+), 20 deletions(-)
create mode 100644 tests/tcg/s390x/trap.c
[PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by Jonathan Albrecht 2 years, 9 months ago 
qemu-s390x signals with SIGILL on compare-and-trap instructions. This
breaks OpenJDK which expects SIGFPE in its implementation of implicit
exceptions.

This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE
psw.addr reporting
https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/

Based-on: 20210705210434.45824-1-iii@linux.ibm.com

v1 -> v2:
- Update to latest version of '... psw.addr reporting' patch
- Rebase to master and fix conflicts in tests/tcg/s390x/Makefile.target

v2 -> v3:
- Check for non-simulated IEEE exception DXC codes explicitly when
  getting si_codes
- Ensure si_code is set in all cases
- Improve comments

Jonathan Albrecht (2):
  linux-user/s390x: signal with SIGFPE on compare-and-trap
  tests/tcg: Test that compare-and-trap raises SIGFPE

 linux-user/s390x/cpu_loop.c     |  54 ++++++++++-------
 tests/tcg/s390x/Makefile.target |   1 +
 tests/tcg/s390x/trap.c          | 102 ++++++++++++++++++++++++++++++++
 3 files changed, 137 insertions(+), 20 deletions(-)
 create mode 100644 tests/tcg/s390x/trap.c

-- 
2.31.1
Re: [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by Laurent Vivier 2 years, 9 months ago 
Le 09/07/2021 à 18:04, Jonathan Albrecht a écrit :
> qemu-s390x signals with SIGILL on compare-and-trap instructions. This
> breaks OpenJDK which expects SIGFPE in its implementation of implicit
> exceptions.
> 
> This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE
> psw.addr reporting
> https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/
> 
> Based-on: 20210705210434.45824-1-iii@linux.ibm.com
> 
> v1 -> v2:
> - Update to latest version of '... psw.addr reporting' patch
> - Rebase to master and fix conflicts in tests/tcg/s390x/Makefile.target
> 
> v2 -> v3:
> - Check for non-simulated IEEE exception DXC codes explicitly when
>   getting si_codes
> - Ensure si_code is set in all cases
> - Improve comments
> 
> Jonathan Albrecht (2):
>   linux-user/s390x: signal with SIGFPE on compare-and-trap
>   tests/tcg: Test that compare-and-trap raises SIGFPE
> 
>  linux-user/s390x/cpu_loop.c     |  54 ++++++++++-------
>  tests/tcg/s390x/Makefile.target |   1 +
>  tests/tcg/s390x/trap.c          | 102 ++++++++++++++++++++++++++++++++
>  3 files changed, 137 insertions(+), 20 deletions(-)
>  create mode 100644 tests/tcg/s390x/trap.c
> 

Series applied to my linux-user-for-6.1 branch.

Thanks,
Laurent
Re: [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by jonathan.albrecht 2 years, 9 months ago 
On 2021-07-12 4:02 pm, Laurent Vivier wrote:
> Le 09/07/2021 à 18:04, Jonathan Albrecht a écrit :
>> qemu-s390x signals with SIGILL on compare-and-trap instructions. This
>> breaks OpenJDK which expects SIGFPE in its implementation of implicit
>> exceptions.
>> 
>> This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and 
>> SIGFPE
>> psw.addr reporting
>> https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/
>> 
>> Based-on: 20210705210434.45824-1-iii@linux.ibm.com
>> 
>> 
> 
> Series applied to my linux-user-for-6.1 branch.
> 

Thanks Laurent, I see this series has been applied to 
https://github.com/vivier/qemu/commits/linux-user-for-6.1 but the 
following series that this is based on also needs to be applied:

https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/

Did some local testing and looks like missing that series caused 
https://app.travis-ci.com/github/vivier/qemu/jobs/523853464 to fail.

Oh, just saw Ilya's email that the test patch has not been reviewed. 
Hopefully that can happen so they can both make it in.

Thanks,

Jon
Re: [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Posted by Laurent Vivier 2 years, 9 months ago 
Le 12/07/2021 à 23:29, jonathan.albrecht a écrit :
> On 2021-07-12 4:02 pm, Laurent Vivier wrote:
>> Le 09/07/2021 à 18:04, Jonathan Albrecht a écrit :
>>> qemu-s390x signals with SIGILL on compare-and-trap instructions. This
>>> breaks OpenJDK which expects SIGFPE in its implementation of implicit
>>> exceptions.
>>>
>>> This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE
>>> psw.addr reporting
>>> https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/
>>>
>>> Based-on: 20210705210434.45824-1-iii@linux.ibm.com
>>>
>>>
>>
>> Series applied to my linux-user-for-6.1 branch.
>>
> 
> Thanks Laurent, I see this series has been applied to
> https://github.com/vivier/qemu/commits/linux-user-for-6.1 but the following series that this is
> based on also needs to be applied:
> 
> https://lore.kernel.org/qemu-devel/20210705210434.45824-1-iii@linux.ibm.com/
> 
> Did some local testing and looks like missing that series caused
> https://app.travis-ci.com/github/vivier/qemu/jobs/523853464 to fail.
> 
> Oh, just saw Ilya's email that the test patch has not been reviewed. Hopefully that can happen so
> they can both make it in.

I've removed these two patches from my patch queue. I'll do a new one with both series when they
will be ready.

Thanks,
Laurent

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.