[v3] linux-user: target <-> host errno conversion code refactor

[PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

Now than target_to_host_errno() always return an errno, we can
remove the unused and arbitrary ERRNO_TABLE_SIZE definition.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 linux-user/syscall.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 94ec6f730b3..376629c6891 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -507,8 +507,6 @@ static inline int next_free_host_timer(void)
 }
 #endif
 
-#define ERRNO_TABLE_SIZE 1200
-
 static inline int host_to_target_errno(int host_errno)
 {
     switch (host_errno) {
@@ -548,9 +546,6 @@ const char *target_strerror(int err)
         return "Successful exit from sigreturn";
     }
 
-    if ((err >= ERRNO_TABLE_SIZE) || (err < 0)) {
-        return NULL;
-    }
     return strerror(target_to_host_errno(err));
 }
 
-- 
2.31.1

Re: [PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check

Posted by Richard Henderson 4 years, 7 months ago

On 7/8/21 10:05 AM, Philippe Mathieu-Daudé wrote:
> Now than target_to_host_errno() always return an errno, we can
> remove the unused and arbitrary ERRNO_TABLE_SIZE definition.
> 
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   linux-user/syscall.c | 5 -----
>   1 file changed, 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check

Posted by Laurent Vivier 4 years, 7 months ago

Le 08/07/2021 à 19:05, Philippe Mathieu-Daudé a écrit :
> Now than target_to_host_errno() always return an errno, we can
> remove the unused and arbitrary ERRNO_TABLE_SIZE definition.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/syscall.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 94ec6f730b3..376629c6891 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -507,8 +507,6 @@ static inline int next_free_host_timer(void)
>  }
>  #endif
>  
> -#define ERRNO_TABLE_SIZE 1200
> -
>  static inline int host_to_target_errno(int host_errno)
>  {
>      switch (host_errno) {
> @@ -548,9 +546,6 @@ const char *target_strerror(int err)
>          return "Successful exit from sigreturn";
>      }
>  
> -    if ((err >= ERRNO_TABLE_SIZE) || (err < 0)) {
> -        return NULL;
> -    }
>      return strerror(target_to_host_errno(err));
>  }
>  
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>