migration: fix typo in mig_throttle_guest_down comment

[PATCH v1] migration: fix typo in mig_throttle_guest_down comment

Posted by Olaf Hering 4 years, 7 months ago

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
all functions comments")

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e..88ff34f574 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest
  *
  * Reduce amount of guest cpu execution to hopefully slow down memory
  * writes. If guest dirty memory rate is reduced below the rate at

Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment

Posted by Dr. David Alan Gilbert 4 years, 7 months ago

* Olaf Hering (olaf@aepfle.de) wrote:
> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
> all functions comments")
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 723af67c2e..88ff34f574 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>  }
>  
>  /**
> - * mig_throttle_guest_down: throotle down the guest
> + * mig_throttle_guest_down: throttle down the guest

Ah yes, Juan frequently throotles.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>   *
>   * Reduce amount of guest cpu execution to hopefully slow down memory
>   * writes. If guest dirty memory rate is reduced below the rate at
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

On 7/8/21 6:36 PM, Dr. David Alan Gilbert wrote:
> * Olaf Hering (olaf@aepfle.de) wrote:
>> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
>> all functions comments")
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> ---
>>  migration/ram.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index 723af67c2e..88ff34f574 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>>  }
>>  
>>  /**
>> - * mig_throttle_guest_down: throotle down the guest
>> + * mig_throttle_guest_down: throttle down the guest
> 
> Ah yes, Juan frequently throotles.

=)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment

Posted by Laurent Vivier 4 years, 7 months ago

Le 08/07/2021 à 18:21, Olaf Hering a écrit :
> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
> all functions comments")
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 723af67c2e..88ff34f574 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>  }
>  
>  /**
> - * mig_throttle_guest_down: throotle down the guest
> + * mig_throttle_guest_down: throttle down the guest
>   *
>   * Reduce amount of guest cpu execution to hopefully slow down memory
>   * writes. If guest dirty memory rate is reduced below the rate at
> 

Applied to my trivial-patches branch.

Thanks,
Laurent