[v2] linux-user: target <-> host errno conversion code refactor

[PATCH v2 2/8] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

We want to have one generic target_errno.h (API to access target
errno), and will add target errno definitions in target_errno_defs.h.
The sparc target already have its errnos in an header, simply rename
it.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 linux-user/sparc/{target_errno.h => target_errno_defs.h} | 4 ++--
 linux-user/sparc/target_syscall.h                        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
 rename linux-user/sparc/{target_errno.h => target_errno_defs.h} (99%)

diff --git a/linux-user/sparc/target_errno.h b/linux-user/sparc/target_errno_defs.h
similarity index 99%
rename from linux-user/sparc/target_errno.h
rename to linux-user/sparc/target_errno_defs.h
index 9b846899cd4..e0008109867 100644
--- a/linux-user/sparc/target_errno.h
+++ b/linux-user/sparc/target_errno_defs.h
@@ -1,5 +1,5 @@
-#ifndef SPARC_TARGET_ERRNO_H
-#define SPARC_TARGET_ERRNO_H
+#ifndef SPARC_TARGET_ERRNO_DEFS_H
+#define SPARC_TARGET_ERRNO_DEFS_H
 
 /* Target errno definitions taken from asm-sparc/errno.h */
 #undef TARGET_EWOULDBLOCK
diff --git a/linux-user/sparc/target_syscall.h b/linux-user/sparc/target_syscall.h
index 15d531f3897..dad501d008c 100644
--- a/linux-user/sparc/target_syscall.h
+++ b/linux-user/sparc/target_syscall.h
@@ -1,7 +1,7 @@
 #ifndef SPARC_TARGET_SYSCALL_H
 #define SPARC_TARGET_SYSCALL_H
 
-#include "target_errno.h"
+#include "target_errno_defs.h"
 
 #if defined(TARGET_SPARC64) && !defined(TARGET_ABI32)
 struct target_pt_regs {
-- 
2.31.1

Re: [PATCH v2 2/8] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h

Posted by Laurent Vivier 4 years, 7 months ago

Le 08/07/2021 à 16:11, Philippe Mathieu-Daudé a écrit :
> We want to have one generic target_errno.h (API to access target
> errno), and will add target errno definitions in target_errno_defs.h.
> The sparc target already have its errnos in an header, simply rename
> it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/sparc/{target_errno.h => target_errno_defs.h} | 4 ++--
>  linux-user/sparc/target_syscall.h                        | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>  rename linux-user/sparc/{target_errno.h => target_errno_defs.h} (99%)
> 
> diff --git a/linux-user/sparc/target_errno.h b/linux-user/sparc/target_errno_defs.h
> similarity index 99%
> rename from linux-user/sparc/target_errno.h
> rename to linux-user/sparc/target_errno_defs.h
> index 9b846899cd4..e0008109867 100644
> --- a/linux-user/sparc/target_errno.h
> +++ b/linux-user/sparc/target_errno_defs.h
> @@ -1,5 +1,5 @@
> -#ifndef SPARC_TARGET_ERRNO_H
> -#define SPARC_TARGET_ERRNO_H
> +#ifndef SPARC_TARGET_ERRNO_DEFS_H
> +#define SPARC_TARGET_ERRNO_DEFS_H
>  
>  /* Target errno definitions taken from asm-sparc/errno.h */
>  #undef TARGET_EWOULDBLOCK
> diff --git a/linux-user/sparc/target_syscall.h b/linux-user/sparc/target_syscall.h
> index 15d531f3897..dad501d008c 100644
> --- a/linux-user/sparc/target_syscall.h
> +++ b/linux-user/sparc/target_syscall.h
> @@ -1,7 +1,7 @@
>  #ifndef SPARC_TARGET_SYSCALL_H
>  #define SPARC_TARGET_SYSCALL_H
>  
> -#include "target_errno.h"
> +#include "target_errno_defs.h"
>  
>  #if defined(TARGET_SPARC64) && !defined(TARGET_ABI32)
>  struct target_pt_regs {
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH v2 2/8] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h

Posted by Richard Henderson 4 years, 7 months ago

On 7/8/21 7:11 AM, Philippe Mathieu-Daudé wrote:
> We want to have one generic target_errno.h (API to access target
> errno), and will add target errno definitions in target_errno_defs.h.
> The sparc target already have its errnos in an header, simply rename
> it.
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   linux-user/sparc/{target_errno.h => target_errno_defs.h} | 4 ++--
>   linux-user/sparc/target_syscall.h                        | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>   rename linux-user/sparc/{target_errno.h => target_errno_defs.h} (99%)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~