virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

[PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

David Hildenbrand posted 2 patches 2 years, 9 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210707140655.30982-1-david@redhat.com

hw/virtio/vhost-user.c             |  2 +-
hw/virtio/virtio-balloon.c         | 26 ++++++++++++++++++++++++++
include/hw/virtio/virtio-balloon.h |  1 +
migration/postcopy-ram.c           |  2 +-
migration/postcopy-ram.h           |  4 ++--
5 files changed, 31 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Posted by David Hildenbrand 2 years, 9 months ago

Working on getting migration for virtio-mem completely right [1] I realized
that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with
postcopy might be shaky. Actually testing it, I directly found two issues,
one of both being far from trivial to fix.

Let's disallow postcopy with "free-page-hint=on".

[1] https://lkml.kernel.org/r/20210616162940.28630-1-david@redhat.com

David Hildenbrand (2):
  migration/postcopy-ram: define type for "struct PostcopyNotifyData"
  virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

 hw/virtio/vhost-user.c             |  2 +-
 hw/virtio/virtio-balloon.c         | 26 ++++++++++++++++++++++++++
 include/hw/virtio/virtio-balloon.h |  1 +
 migration/postcopy-ram.c           |  2 +-
 migration/postcopy-ram.h           |  4 ++--
 5 files changed, 31 insertions(+), 4 deletions(-)

-- 
2.31.1