Fix libdaxctl option

[PATCH] Fix libdaxctl option

Posted by Miroslav Rezanina 4 years, 7 months ago

For some reason, libdaxctl option setting was set to work in an opposite
way (--enable-libdaxctl disabled it and vice versa). Fixing this so
configuration works properly.

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 650d9c0735..4f51528a77 100755
--- a/configure
+++ b/configure
@@ -1531,9 +1531,9 @@ for opt do
   ;;
   --disable-keyring) secret_keyring="no"
   ;;
-  --enable-libdaxctl) libdaxctl=disabled
+  --enable-libdaxctl) libdaxctl="enabled"
   ;;
-  --disable-libdaxctl) libdaxctl=enabled
+  --disable-libdaxctl) libdaxctl="disabled"
   ;;
   --enable-fuse) fuse="enabled"
   ;;
-- 
2.27.0

Re: [PATCH] Fix libdaxctl option

Posted by Thomas Huth 4 years, 7 months ago

On 07/07/2021 08.31, Miroslav Rezanina wrote:
> For some reason, libdaxctl option setting was set to work in an opposite
> way (--enable-libdaxctl disabled it and vice versa). Fixing this so
> configuration works properly.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 650d9c0735..4f51528a77 100755
> --- a/configure
> +++ b/configure
> @@ -1531,9 +1531,9 @@ for opt do
>     ;;
>     --disable-keyring) secret_keyring="no"
>     ;;
> -  --enable-libdaxctl) libdaxctl=disabled
> +  --enable-libdaxctl) libdaxctl="enabled"
>     ;;
> -  --disable-libdaxctl) libdaxctl=enabled
> +  --disable-libdaxctl) libdaxctl="disabled"
>     ;;
>     --enable-fuse) fuse="enabled"
>     ;;
> 

Fixes: 83ef16821a ("configure, meson: convert libdaxctl detection to meson")

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] Fix libdaxctl option

Posted by Philippe Mathieu-Daudé 4 years, 7 months ago

On 7/7/21 8:35 AM, Thomas Huth wrote:
> On 07/07/2021 08.31, Miroslav Rezanina wrote:
>> For some reason, libdaxctl option setting was set to work in an opposite
>> way (--enable-libdaxctl disabled it and vice versa). Fixing this so
>> configuration works properly.
>>
>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>> ---
>>   configure | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 650d9c0735..4f51528a77 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1531,9 +1531,9 @@ for opt do
>>     ;;
>>     --disable-keyring) secret_keyring="no"
>>     ;;
>> -  --enable-libdaxctl) libdaxctl=disabled
>> +  --enable-libdaxctl) libdaxctl="enabled"
>>     ;;
>> -  --disable-libdaxctl) libdaxctl=enabled
>> +  --disable-libdaxctl) libdaxctl="disabled"
>>     ;;
>>     --enable-fuse) fuse="enabled"
>>     ;;
>>
> 
> Fixes: 83ef16821a ("configure, meson: convert libdaxctl detection to
> meson")
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>