tcg: Add separator in INDEX_op_call dump

[PATCH] tcg: Add separator in INDEX_op_call dump

Richard Henderson posted 1 patch 2 years, 10 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210707000414.358112-1-richard.henderson@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>

tcg/tcg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tcg: Add separator in INDEX_op_call dump

Posted by Richard Henderson 2 years, 10 months ago

We lost the ',' following the called function name.

Fixes: 3e92aa34434
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/tcg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/tcg.c b/tcg/tcg.c
index 5150ed700e..4dd4084419 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1849,7 +1849,7 @@ static void tcg_dump_ops(TCGContext *s, bool have_prefs)
                 col += qemu_log("plugin(%p)", func);
             }
 
-            col += qemu_log("$0x%x,$%d", info->flags, nb_oargs);
+            col += qemu_log(",$0x%x,$%d", info->flags, nb_oargs);
             for (i = 0; i < nb_oargs; i++) {
                 col += qemu_log(",%s", tcg_get_arg_str(s, buf, sizeof(buf),
                                                        op->args[i]));
-- 
2.25.1

Re: [PATCH] tcg: Add separator in INDEX_op_call dump

Posted by Philippe Mathieu-Daudé 2 years, 10 months ago

On 7/7/21 2:04 AM, Richard Henderson wrote:
> We lost the ',' following the called function name.
> 
> Fixes: 3e92aa34434
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/tcg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>