[PATCH v1 05/39] tests/tcg: generalise the disabling of the signals test

Alex Bennée posted 39 patches 4 years, 5 months ago
Maintainers: Kamil Rytarowski <kamil@netbsd.org>, Reinoud Zandijk <reinoud@netbsd.org>, Ryo ONODERA <ryoon@netbsd.org>, Brad Smith <brad@comstyle.com>
[PATCH v1 05/39] tests/tcg: generalise the disabling of the signals test
Posted by Alex Bennée 4 years, 5 months ago
It turns out you push down in one place and failures pop-up elsewhere.
Especially on CI. Disable for now for all targets.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/tcg/hppa/Makefile.target      | 3 ---
 tests/tcg/multiarch/Makefile.target | 6 ++++++
 tests/tcg/s390x/Makefile.target     | 3 ---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
index 71791235f6..473864d1d4 100644
--- a/tests/tcg/hppa/Makefile.target
+++ b/tests/tcg/hppa/Makefile.target
@@ -5,6 +5,3 @@
 # On parisc Linux supports 4K/16K/64K (but currently only 4k works)
 EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
 
-# There is a race that causes this to fail about 1% of the time
-run-signals: signals
-	$(call skip-test, $<, "BROKEN awaiting vdso support")
diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target
index 3f283eabe6..d57a115873 100644
--- a/tests/tcg/multiarch/Makefile.target
+++ b/tests/tcg/multiarch/Makefile.target
@@ -32,6 +32,12 @@ threadcount: LDFLAGS+=-lpthread
 
 signals: LDFLAGS+=-lrt -lpthread
 
+# This triggers failures on s390x hosts about 4% of the time
+# This triggers failures for hppa-linux about 1% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups and vdso support")
+
+
 # We define the runner for test-mmap after the individual
 # architectures have defined their supported pages sizes. If no
 # additional page sizes are defined we only run the default test.
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
index 0036b8a505..5d3de1b27a 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tests/tcg/s390x/Makefile.target
@@ -9,6 +9,3 @@ TESTS+=pack
 TESTS+=mvo
 TESTS+=mvc
 
-# This triggers failures on s390x hosts about 4% of the time
-run-signals: signals
-	$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups")
-- 
2.20.1


Re: [PATCH v1 05/39] tests/tcg: generalise the disabling of the signals test
Posted by Peter Maydell 4 years, 5 months ago
On Tue, 6 Jul 2021 at 16:07, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> It turns out you push down in one place and failures pop-up elsewhere.
> Especially on CI. Disable for now for all targets.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/tcg/hppa/Makefile.target      | 3 ---
>  tests/tcg/multiarch/Makefile.target | 6 ++++++
>  tests/tcg/s390x/Makefile.target     | 3 ---

I've cherry-picked this one to reduce the intermittent CI failures.

thanks
-- PMM