[PATCH 2/4] hw/nvme: mark nvme-subsys non-hotpluggable

Klaus Jensen posted 4 patches 4 years, 7 months ago
Maintainers: Klaus Jensen <its@irrelevant.dk>, Keith Busch <kbusch@kernel.org>
There is a newer version of this series
[PATCH 2/4] hw/nvme: mark nvme-subsys non-hotpluggable
Posted by Klaus Jensen 4 years, 7 months ago
From: Klaus Jensen <k.jensen@samsung.com>

We currently lack the infrastructure to handle subsystem hotplugging, so
disable it.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/nvme/subsys.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c
index 192223d17ca1..dc7a96862f37 100644
--- a/hw/nvme/subsys.c
+++ b/hw/nvme/subsys.c
@@ -61,6 +61,7 @@ static void nvme_subsys_class_init(ObjectClass *oc, void *data)
 
     dc->realize = nvme_subsys_realize;
     dc->desc = "Virtual NVMe subsystem";
+    dc->hotpluggable = false;
 
     device_class_set_props(dc, nvme_subsystem_props);
 }
-- 
2.32.0


Re: [PATCH 2/4] hw/nvme: mark nvme-subsys non-hotpluggable
Posted by Hannes Reinecke 4 years, 7 months ago
On 7/6/21 11:33 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> We currently lack the infrastructure to handle subsystem hotplugging, so
> disable it.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/nvme/subsys.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c
> index 192223d17ca1..dc7a96862f37 100644
> --- a/hw/nvme/subsys.c
> +++ b/hw/nvme/subsys.c
> @@ -61,6 +61,7 @@ static void nvme_subsys_class_init(ObjectClass *oc, void *data)
>   
>       dc->realize = nvme_subsys_realize;
>       dc->desc = "Virtual NVMe subsystem";
> +    dc->hotpluggable = false;
>   
>       device_class_set_props(dc, nvme_subsystem_props);
>   }
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer