colo: Don't dump colo cache if dump-guest-core=off

[PATCH] colo: Don't dump colo cache if dump-guest-core=off

Lukas Straub posted 1 patch 4 years, 7 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210704181444.59396f6b@gecko.fritz.box

Maintainers: Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

migration/ram.c | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[PATCH] colo: Don't dump colo cache if dump-guest-core=off

Posted by Lukas Straub 4 years, 7 months ago

One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
 migration/ram.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e..0797d0d222 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
 #include "multifd.h"
 #include "sysemu/runstate.h"
 
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
 #if defined(__linux__)
 #include "qemu/userfaultfd.h"
 #endif /* defined(__linux__) */
@@ -3356,6 +3358,10 @@ int colo_init_ram_cache(void)
                 }
                 return -errno;
             }
+            if (!machine_dump_guest_core(current_machine)) {
+                qemu_madvise(block->colo_cache, block->used_length,
+                             QEMU_MADV_DONTDUMP);
+            }
         }
     }
 
-- 
2.20.1

Re: [PATCH] colo: Don't dump colo cache if dump-guest-core=off

Posted by Juan Quintela 4 years, 3 months ago

Lukas Straub <lukasstraub2@web.de> wrote:
> One might set dump-guest-core=off to make coredumps smaller and
> still allow to debug many qemu bugs. Extend this option to the colo
> cache.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>

Reviewed-by: Juan Quintela <quintela@redhat.com>