target/i386: Remove split lock detect in Snowridge CPU model

[PATCH] target/i386: Remove split lock detect in Snowridge CPU model

Chenyi Qiang posted 1 patch 2 years, 10 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210630012053.10098-1-chenyi.qiang@intel.com

target/i386/cpu.c | 8 ++++++++
1 file changed, 8 insertions(+)

Expand all Fold all

[PATCH] target/i386: Remove split lock detect in Snowridge CPU model

Posted by Chenyi Qiang 2 years, 10 months ago

At present, there's no mechanism intelligent enough to virtualize split
lock detection correctly. Remove it in Snowridge CPU model to avoid the
feature exposure.

Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
---
 target/i386/cpu.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index a9fe1662d3..c3b527b7b0 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3698,6 +3698,14 @@ static const X86CPUDefinition builtin_x86_defs[] = {
                     { /* end of list */ },
                 },
             },
+            {
+                .version = 4,
+                .note = "no split lock detect",
+                .props = (PropValue[]) {
+                    { "split-lock-detect", "off" },
+                    { /* end of list */ },
+                },
+            },
             { /* end of list */ },
         },
     },
-- 
2.17.1

Re: [PATCH] target/i386: Remove split lock detect in Snowridge CPU model

Posted by Eduardo Habkost 2 years, 8 months ago

On Wed, Jun 30, 2021 at 09:20:53AM +0800, Chenyi Qiang wrote:
> At present, there's no mechanism intelligent enough to virtualize split
> lock detection correctly. Remove it in Snowridge CPU model to avoid the
> feature exposure.
> 
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>

Sorry I have missed this before 6.1 soft freeze.  I'm queueing
this for 6.2.  Thanks!

-- 
Eduardo