[v1] python/iotests: Run iotest linters during Python CI

[PATCH 10/10] python: Add iotest linters to test suite

Posted by John Snow 4 years, 7 months ago

As a convenience, since iotests is an extremely prominent user of the
qemu.qmp and qemu.machine packages and already implements a linting
regime, run those tests as well so that it's very hard to miss
regressions caused by changes to the python library.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/tests/iotests.sh | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100755 python/tests/iotests.sh

diff --git a/python/tests/iotests.sh b/python/tests/iotests.sh
new file mode 100755
index 0000000000..ec2fc58066
--- /dev/null
+++ b/python/tests/iotests.sh
@@ -0,0 +1,2 @@
+#!/bin/sh -e
+PYTHONPATH=../tests/qemu-iotests/ python3 -m linters
-- 
2.31.1

Re: [PATCH 10/10] python: Add iotest linters to test suite

Posted by Vladimir Sementsov-Ogievskiy 4 years, 7 months ago

25.06.2021 21:20, John Snow wrote:
> As a convenience, since iotests is an extremely prominent user of the
> qemu.qmp and qemu.machine packages and already implements a linting
> regime, run those tests as well so that it's very hard to miss
> regressions caused by changes to the python library.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   python/tests/iotests.sh | 2 ++
>   1 file changed, 2 insertions(+)
>   create mode 100755 python/tests/iotests.sh
> 
> diff --git a/python/tests/iotests.sh b/python/tests/iotests.sh
> new file mode 100755
> index 0000000000..ec2fc58066
> --- /dev/null
> +++ b/python/tests/iotests.sh
> @@ -0,0 +1,2 @@
> +#!/bin/sh -e
> +PYTHONPATH=../tests/qemu-iotests/ python3 -m linters
> 


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir