[PATCH 09/11] python: Update help text on 'make check', 'make develop'

John Snow posted 11 patches 4 years, 7 months ago
Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Willian Rampazzo <willianr@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Cleber Rosa <crosa@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, John Snow <jsnow@redhat.com>, Thomas Huth <thuth@redhat.com>
There is a newer version of this series
[PATCH 09/11] python: Update help text on 'make check', 'make develop'
Posted by John Snow 4 years, 7 months ago
Update for visual parity with the other targets.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/Makefile | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/python/Makefile b/python/Makefile
index 76bb24e671..4ed37c29f0 100644
--- a/python/Makefile
+++ b/python/Makefile
@@ -22,10 +22,14 @@ help:
 	@echo "    These tests use the newest dependencies."
 	@echo "    Requires: Python 3.x"
 	@echo ""
-	@echo "make develop:    Install deps for 'make check', and"
-	@echo "                 the qemu libs in editable/development mode."
+	@echo "make check:"
+	@echo "    Run tests in your *current environment*."
+	@echo "    Performs no environment setup of any kind."
 	@echo ""
-	@echo "make check:      run linters using the current environment."
+	@echo "make develop:"
+	@echo "    Install deps needed for for 'make check',"
+	@echo "    and install the qemu package in editable mode."
+	@echo "    (Can be used in or outside of a venv.)"
 	@echo ""
 	@echo "make pipenv"
 	@echo "    Creates pipenv's virtual environment (.venv)"
-- 
2.31.1


Re: [PATCH 09/11] python: Update help text on 'make check', 'make develop'
Posted by Willian Rampazzo 4 years, 7 months ago
On Fri, Jun 25, 2021 at 12:46 PM John Snow <jsnow@redhat.com> wrote:
>
> Update for visual parity with the other targets.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/Makefile | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>


Re: [PATCH 09/11] python: Update help text on 'make check', 'make develop'
Posted by Wainer dos Santos Moschetta 4 years, 7 months ago
On 6/25/21 12:45 PM, John Snow wrote:
> Update for visual parity with the other targets.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   python/Makefile | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/python/Makefile b/python/Makefile
> index 76bb24e671..4ed37c29f0 100644
> --- a/python/Makefile
> +++ b/python/Makefile
> @@ -22,10 +22,14 @@ help:
>   	@echo "    These tests use the newest dependencies."
>   	@echo "    Requires: Python 3.x"
>   	@echo ""
> -	@echo "make develop:    Install deps for 'make check', and"
> -	@echo "                 the qemu libs in editable/development mode."
> +	@echo "make check:"
> +	@echo "    Run tests in your *current environment*."
> +	@echo "    Performs no environment setup of any kind."
>   	@echo ""
> -	@echo "make check:      run linters using the current environment."
> +	@echo "make develop:"
> +	@echo "    Install deps needed for for 'make check',"
> +	@echo "    and install the qemu package in editable mode."
> +	@echo "    (Can be used in or outside of a venv.)"
>   	@echo ""
>   	@echo "make pipenv"
>   	@echo "    Creates pipenv's virtual environment (.venv)"