pc: acpi: revert back to 5.2 PCI slot enumeration

[PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

Posted by Igor Mammedov 4 years, 7 months ago

Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices),
regressed network interface naming for Linux guests in some cases.
This reverts PCI slot enumeration to its state before 6.0.
For details see 2/3 patch.

Thanks Stefan for troubleshooting!

Reported-by: john.sucaet@ekinops.com  
CC: stefanha@redhat.com
CC: qemu-stable@nongnu.org
CC: mst@redhat.com
CC: marcel.apfelbaum@gmail.com
CC: berrange@redhat.com

Igor Mammedov (2):
  tests: acpi: prepare for changing DSDT tables
  acpi: pc: revert back to v5.2 PCI slot enumeration

 tests/qtest/bios-tables-test-allowed-diff.h | 10 ++++++++++
 hw/i386/acpi-build.c                        |  9 +++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)

-- 
2.27.0

Re: [PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

Posted by John Sucaet 4 years, 7 months ago

Tested-by: John Sucaet <john.sucaet@ekinops.com>

On 6/24/21 10:42 PM, Igor Mammedov wrote:
> Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices),
> regressed network interface naming for Linux guests in some cases.
> This reverts PCI slot enumeration to its state before 6.0.
> For details see 2/3 patch.
>
> Thanks Stefan for troubleshooting!
>
> Reported-by: john.sucaet@ekinops.com
> CC: stefanha@redhat.com
> CC: qemu-stable@nongnu.org
> CC: mst@redhat.com
> CC: marcel.apfelbaum@gmail.com
> CC: berrange@redhat.com
>
> Igor Mammedov (2):
>    tests: acpi: prepare for changing DSDT tables
>    acpi: pc: revert back to v5.2 PCI slot enumeration
>
>   tests/qtest/bios-tables-test-allowed-diff.h | 10 ++++++++++
>   hw/i386/acpi-build.c                        |  9 +++++++--
>   2 files changed, 17 insertions(+), 2 deletions(-)
>

Re: [PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

Posted by Stefan Hajnoczi 4 years, 7 months ago

On Thu, Jun 24, 2021 at 04:42:26PM -0400, Igor Mammedov wrote:
> Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices),
> regressed network interface naming for Linux guests in some cases.
> This reverts PCI slot enumeration to its state before 6.0.
> For details see 2/3 patch.
> 
> Thanks Stefan for troubleshooting!
> 
> Reported-by: john.sucaet@ekinops.com  
> CC: stefanha@redhat.com
> CC: qemu-stable@nongnu.org
> CC: mst@redhat.com
> CC: marcel.apfelbaum@gmail.com
> CC: berrange@redhat.com
> 
> Igor Mammedov (2):
>   tests: acpi: prepare for changing DSDT tables
>   acpi: pc: revert back to v5.2 PCI slot enumeration
> 
>  tests/qtest/bios-tables-test-allowed-diff.h | 10 ++++++++++
>  hw/i386/acpi-build.c                        |  9 +++++++--
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> -- 
> 2.27.0
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH 0/2] pc: acpi: revert back to 5.2 PCI slot enumeration

Posted by Michael S. Tsirkin 4 years, 7 months ago

On Mon, Jun 28, 2021 at 02:06:01PM +0100, Stefan Hajnoczi wrote:
> On Thu, Jun 24, 2021 at 04:42:26PM -0400, Igor Mammedov wrote:
> > Commit b7f23f62e40 (pci: acpi: add _DSM method to PCI devices),
> > regressed network interface naming for Linux guests in some cases.
> > This reverts PCI slot enumeration to its state before 6.0.
> > For details see 2/3 patch.
> > 
> > Thanks Stefan for troubleshooting!
> > 
> > Reported-by: john.sucaet@ekinops.com  
> > CC: stefanha@redhat.com
> > CC: qemu-stable@nongnu.org
> > CC: mst@redhat.com
> > CC: marcel.apfelbaum@gmail.com
> > CC: berrange@redhat.com
> > 
> > Igor Mammedov (2):
> >   tests: acpi: prepare for changing DSDT tables
> >   acpi: pc: revert back to v5.2 PCI slot enumeration
> > 
> >  tests/qtest/bios-tables-test-allowed-diff.h | 10 ++++++++++
> >  hw/i386/acpi-build.c                        |  9 +++++++--
> >  2 files changed, 17 insertions(+), 2 deletions(-)
> > 
> > -- 
> > 2.27.0
> > 
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Tagged, thanks!