1. Patchew
  2. QEMU
  3. [RFC PATCH 0/9] hw/sd: Allow card size not power of 2 again
  4. View patch

[PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

Philippe Mathieu-Daudé posted 9 patches 4 years, 7 months ago
[PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago 
Avocado allows us to select set of tests using tags.
When wanting to run all tests using a NetBSD guest OS,
it is convenient to have them tagged, add the 'os:netbsd'
tag.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/acceptance/boot_linux_console.py | 1 +
 tests/acceptance/ppc_prep_40p.py       | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index cded547d1d4..20d57c1a8c6 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -862,6 +862,7 @@ def test_arm_orangepi_uboot_netbsd9(self):
         :avocado: tags=arch:arm
         :avocado: tags=machine:orangepi-pc
         :avocado: tags=device:sd
+        :avocado: tags=os:netbsd
         """
         # This test download a 304MB compressed image and expand it to 2GB
         deb_url = ('http://snapshot.debian.org/archive/debian/'
diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
index 96ba13b8943..2993ee3b078 100644
--- a/tests/acceptance/ppc_prep_40p.py
+++ b/tests/acceptance/ppc_prep_40p.py
@@ -27,6 +27,7 @@ def test_factory_firmware_and_netbsd(self):
         """
         :avocado: tags=arch:ppc
         :avocado: tags=machine:40p
+        :avocado: tags=os:netbsd
         :avocado: tags=slowness:high
         """
         bios_url = ('http://ftpmirror.your.org/pub/misc/'
@@ -64,6 +65,7 @@ def test_openbios_and_netbsd(self):
         """
         :avocado: tags=arch:ppc
         :avocado: tags=machine:40p
+        :avocado: tags=os:netbsd
         """
         drive_url = ('https://cdn.netbsd.org/pub/NetBSD/iso/7.1.2/'
                      'NetBSD-7.1.2-prep.iso')
-- 
2.31.1
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Willian Rampazzo 4 years, 7 months ago 
On Wed, Jun 23, 2021 at 3:03 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Avocado allows us to select set of tests using tags.
> When wanting to run all tests using a NetBSD guest OS,
> it is convenient to have them tagged, add the 'os:netbsd'
> tag.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  tests/acceptance/boot_linux_console.py | 1 +
>  tests/acceptance/ppc_prep_40p.py       | 2 ++
>  2 files changed, 3 insertions(+)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Cleber Rosa 4 years, 7 months ago 
Philippe Mathieu-Daudé writes:

> Avocado allows us to select set of tests using tags.
> When wanting to run all tests using a NetBSD guest OS,
> it is convenient to have them tagged, add the 'os:netbsd'
> tag.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  tests/acceptance/boot_linux_console.py | 1 +
>  tests/acceptance/ppc_prep_40p.py       | 2 ++
>  2 files changed, 3 insertions(+)

Reviewed-by: Cleber Rosa <crosa@redhat.com>

Phil,

I can ammend the commit message and queue this one if you think it's a
good idea.

Cheers,
- Cleber.
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago 
CC'ing NetBSD maintainers.

On 6/23/21 8:00 PM, Philippe Mathieu-Daudé wrote:
> Avocado allows us to select set of tests using tags.
> When wanting to run all tests using a NetBSD guest OS,
> it is convenient to have them tagged, add the 'os:netbsd'
> tag.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  tests/acceptance/boot_linux_console.py | 1 +
>  tests/acceptance/ppc_prep_40p.py       | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index cded547d1d4..20d57c1a8c6 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -862,6 +862,7 @@ def test_arm_orangepi_uboot_netbsd9(self):
>          :avocado: tags=arch:arm
>          :avocado: tags=machine:orangepi-pc
>          :avocado: tags=device:sd
> +        :avocado: tags=os:netbsd
>          """
>          # This test download a 304MB compressed image and expand it to 2GB
>          deb_url = ('http://snapshot.debian.org/archive/debian/'
> diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
> index 96ba13b8943..2993ee3b078 100644
> --- a/tests/acceptance/ppc_prep_40p.py
> +++ b/tests/acceptance/ppc_prep_40p.py
> @@ -27,6 +27,7 @@ def test_factory_firmware_and_netbsd(self):
>          """
>          :avocado: tags=arch:ppc
>          :avocado: tags=machine:40p
> +        :avocado: tags=os:netbsd
>          :avocado: tags=slowness:high
>          """
>          bios_url = ('http://ftpmirror.your.org/pub/misc/'
> @@ -64,6 +65,7 @@ def test_openbios_and_netbsd(self):
>          """
>          :avocado: tags=arch:ppc
>          :avocado: tags=machine:40p
> +        :avocado: tags=os:netbsd
>          """
>          drive_url = ('https://cdn.netbsd.org/pub/NetBSD/iso/7.1.2/'
>                       'NetBSD-7.1.2-prep.iso')
>
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago 
On Sat, Jul 3, 2021 at 10:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> CC'ing NetBSD maintainers.
>
> On 6/23/21 8:00 PM, Philippe Mathieu-Daudé wrote:
> > Avocado allows us to select set of tests using tags.
> > When wanting to run all tests using a NetBSD guest OS,
> > it is convenient to have them tagged, add the 'os:netbsd'
> > tag.

I'll amend an command line example to run the NetBSD tests:

   $ avocado --show=app,console run -t os:netbsd tests/acceptance/

> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  tests/acceptance/boot_linux_console.py | 1 +
> >  tests/acceptance/ppc_prep_40p.py       | 2 ++
> >  2 files changed, 3 insertions(+)
> >
> > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> > index cded547d1d4..20d57c1a8c6 100644
> > --- a/tests/acceptance/boot_linux_console.py
> > +++ b/tests/acceptance/boot_linux_console.py
> > @@ -862,6 +862,7 @@ def test_arm_orangepi_uboot_netbsd9(self):
> >          :avocado: tags=arch:arm
> >          :avocado: tags=machine:orangepi-pc
> >          :avocado: tags=device:sd
> > +        :avocado: tags=os:netbsd
> >          """
> >          # This test download a 304MB compressed image and expand it to 2GB
> >          deb_url = ('http://snapshot.debian.org/archive/debian/'
> > diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
> > index 96ba13b8943..2993ee3b078 100644
> > --- a/tests/acceptance/ppc_prep_40p.py
> > +++ b/tests/acceptance/ppc_prep_40p.py
> > @@ -27,6 +27,7 @@ def test_factory_firmware_and_netbsd(self):
> >          """
> >          :avocado: tags=arch:ppc
> >          :avocado: tags=machine:40p
> > +        :avocado: tags=os:netbsd
> >          :avocado: tags=slowness:high
> >          """
> >          bios_url = ('http://ftpmirror.your.org/pub/misc/'
> > @@ -64,6 +65,7 @@ def test_openbios_and_netbsd(self):
> >          """
> >          :avocado: tags=arch:ppc
> >          :avocado: tags=machine:40p
> > +        :avocado: tags=os:netbsd
> >          """
> >          drive_url = ('https://cdn.netbsd.org/pub/NetBSD/iso/7.1.2/'
> >                       'NetBSD-7.1.2-prep.iso')
> >
>
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Niek Linnenbank 4 years, 7 months ago 
for test_arm_orangepi_uboot_netbsd9:

Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>

Op za 3 jul. 2021 10:44 schreef Philippe Mathieu-Daudé <f4bug@amsat.org>:

> On Sat, Jul 3, 2021 at 10:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> >
> > CC'ing NetBSD maintainers.
> >
> > On 6/23/21 8:00 PM, Philippe Mathieu-Daudé wrote:
> > > Avocado allows us to select set of tests using tags.
> > > When wanting to run all tests using a NetBSD guest OS,
> > > it is convenient to have them tagged, add the 'os:netbsd'
> > > tag.
>
> I'll amend an command line example to run the NetBSD tests:
>
>    $ avocado --show=app,console run -t os:netbsd tests/acceptance/
>
> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > ---
> > >  tests/acceptance/boot_linux_console.py | 1 +
> > >  tests/acceptance/ppc_prep_40p.py       | 2 ++
> > >  2 files changed, 3 insertions(+)
> > >
> > > diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> > > index cded547d1d4..20d57c1a8c6 100644
> > > --- a/tests/acceptance/boot_linux_console.py
> > > +++ b/tests/acceptance/boot_linux_console.py
> > > @@ -862,6 +862,7 @@ def test_arm_orangepi_uboot_netbsd9(self):
> > >          :avocado: tags=arch:arm
> > >          :avocado: tags=machine:orangepi-pc
> > >          :avocado: tags=device:sd
> > > +        :avocado: tags=os:netbsd
> > >          """
> > >          # This test download a 304MB compressed image and expand it
> to 2GB
> > >          deb_url = ('http://snapshot.debian.org/archive/debian/'
> > > diff --git a/tests/acceptance/ppc_prep_40p.py
> b/tests/acceptance/ppc_prep_40p.py
> > > index 96ba13b8943..2993ee3b078 100644
> > > --- a/tests/acceptance/ppc_prep_40p.py
> > > +++ b/tests/acceptance/ppc_prep_40p.py
> > > @@ -27,6 +27,7 @@ def test_factory_firmware_and_netbsd(self):
> > >          """
> > >          :avocado: tags=arch:ppc
> > >          :avocado: tags=machine:40p
> > > +        :avocado: tags=os:netbsd
> > >          :avocado: tags=slowness:high
> > >          """
> > >          bios_url = ('http://ftpmirror.your.org/pub/misc/'
> > > @@ -64,6 +65,7 @@ def test_openbios_and_netbsd(self):
> > >          """
> > >          :avocado: tags=arch:ppc
> > >          :avocado: tags=machine:40p
> > > +        :avocado: tags=os:netbsd
> > >          """
> > >          drive_url = ('https://cdn.netbsd.org/pub/NetBSD/iso/7.1.2/'
> > >                       'NetBSD-7.1.2-prep.iso')
> > >
> >
>
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago 
Hi Niek,

On 7/4/21 2:35 PM, Niek Linnenbank wrote:
> for test_arm_orangepi_uboot_netbsd9:
> 
> Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com
> <mailto:nieklinnenbank@gmail.com>>

Thanks for the review. Does your R-b tag applies for this single
patch or all patches related to test_arm_orangepi_uboot_netbsd9
in this series (3-5)?
Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago 
On 7/5/21 10:55 AM, Philippe Mathieu-Daudé wrote:
> Hi Niek,
> 
> On 7/4/21 2:35 PM, Niek Linnenbank wrote:
>> for test_arm_orangepi_uboot_netbsd9:
>>
>> Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com
>> <mailto:nieklinnenbank@gmail.com>>
> 
> Thanks for the review. Does your R-b tag applies for this single
> patch or all patches related to test_arm_orangepi_uboot_netbsd9
> in this series (3-5)?

Soft-freeze is in 2 days and no review from the NetBSD team,
so postponing these patches to v6.2.

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.