[PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now

Alex Bennée posted 8 patches 4 years, 7 months ago
Maintainers: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>
[PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now
Posted by Alex Bennée 4 years, 7 months ago
There are fixes currently in flight but as this is getting in the way
of a green CI we might as well skip for now. For reference the fix
series are:

  linux-user: Move signal trampolines to new page
  20210616011209.1446045-1-richard.henderson@linaro.org

and

  linux-user: Load a vdso for x86_64 and hppa
  20210619034329.532318-1-richard.henderson@linaro.org

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
---
 tests/tcg/hppa/Makefile.target  | 4 ++++
 tests/tcg/s390x/Makefile.target | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/tests/tcg/hppa/Makefile.target b/tests/tcg/hppa/Makefile.target
index 8bf01966bd..71791235f6 100644
--- a/tests/tcg/hppa/Makefile.target
+++ b/tests/tcg/hppa/Makefile.target
@@ -4,3 +4,7 @@
 
 # On parisc Linux supports 4K/16K/64K (but currently only 4k works)
 EXTRA_RUNS+=run-test-mmap-4096 # run-test-mmap-16384 run-test-mmap-65536
+
+# There is a race that causes this to fail about 1% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting vdso support")
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
index 241ef28f61..0036b8a505 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tests/tcg/s390x/Makefile.target
@@ -8,3 +8,7 @@ TESTS+=exrl-trtr
 TESTS+=pack
 TESTS+=mvo
 TESTS+=mvc
+
+# This triggers failures on s390x hosts about 4% of the time
+run-signals: signals
+	$(call skip-test, $<, "BROKEN awaiting sigframe clean-ups")
-- 
2.20.1


Re: [PATCH v1 6/8] tests/tcg: skip the signals test for hppa/s390x for now
Posted by Cornelia Huck 4 years, 7 months ago
On Wed, Jun 23 2021, Alex Bennée <alex.bennee@linaro.org> wrote:

> There are fixes currently in flight but as this is getting in the way
> of a green CI we might as well skip for now. For reference the fix
> series are:
>
>   linux-user: Move signal trampolines to new page
>   20210616011209.1446045-1-richard.henderson@linaro.org
>
> and
>
>   linux-user: Load a vdso for x86_64 and hppa
>   20210619034329.532318-1-richard.henderson@linaro.org
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tests/tcg/hppa/Makefile.target  | 4 ++++
>  tests/tcg/s390x/Makefile.target | 4 ++++
>  2 files changed, 8 insertions(+)

Acked-by: Cornelia Huck <cohuck@redhat.com>