Add features and cpu models

[PATCH 0/1] Add features and cpu models

Christian Borntraeger posted 1 patch 2 years, 10 months ago

Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210622201923.150205-1-borntraeger@de.ibm.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>

target/s390x/cpu_features_def.h.inc |  5 +++++
target/s390x/cpu_models.c           |  6 ++++++
target/s390x/gen-features.c         | 14 ++++++++++++++
3 files changed, 25 insertions(+)

Expand all Fold all

[PATCH 0/1] Add features and cpu models

Posted by Christian Borntraeger 2 years, 10 months ago

5 new features and 2 new models

Christian Borntraeger (1):
  s390x/cpumodel: add 3931 and 3932

 target/s390x/cpu_features_def.h.inc |  5 +++++
 target/s390x/cpu_models.c           |  6 ++++++
 target/s390x/gen-features.c         | 14 ++++++++++++++
 3 files changed, 25 insertions(+)

-- 
2.31.1

Re: [PATCH 0/1] Add features and cpu models

Posted by no-reply@patchew.org 2 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/20210622201923.150205-1-borntraeger@de.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210622201923.150205-1-borntraeger@de.ibm.com
Subject: [PATCH 0/1] Add features and cpu models

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b71b2c5 s390x/cpumodel: add 3931 and 3932

=== OUTPUT BEGIN ===
ERROR: line over 90 characters
#35: FILE: target/s390x/cpu_features_def.h.inc:113:
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH2, "vxpdeh2", STFL, 192, "Vector-Packed-Decimal-Enhancement facility 2")

WARNING: line over 80 characters
#38: FILE: target/s390x/cpu_features_def.h.inc:116:
+DEF_FEAT(ACTIVITY, "activity", STFL, 196, "Processor-Activity-Instrumentation facility")

WARNING: line over 80 characters
#59: FILE: target/s390x/cpu_models.c:817:
+        { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH, S390_FEAT_VECTOR_PACKED_DECIMAL },

WARNING: line over 80 characters
#60: FILE: target/s390x/cpu_models.c:818:
+        { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2, S390_FEAT_VECTOR_PACKED_DECIMAL_ENH },

total: 1 errors, 3 warnings, 73 lines checked

Commit b71b2c5056b7 (s390x/cpumodel: add 3931 and 3932) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210622201923.150205-1-borntraeger@de.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH 0/1] Add features and cpu models

Posted by Cornelia Huck 2 years, 10 months ago

On Tue, Jun 22 2021, Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> 5 new features and 2 new models
>
> Christian Borntraeger (1):
>   s390x/cpumodel: add 3931 and 3932
>
>  target/s390x/cpu_features_def.h.inc |  5 +++++
>  target/s390x/cpu_models.c           |  6 ++++++
>  target/s390x/gen-features.c         | 14 ++++++++++++++
>  3 files changed, 25 insertions(+)

Thanks, applied.