[PATCH 0/5] [RfC] monitor/hmp: command register support

Gerd Hoffmann posted 5 patches 2 years, 10 months ago
Failed in applying to current master (apply log)
include/hw/usb.h             |  7 +++++-
include/monitor/monitor.h    |  3 +++
accel/tcg/hmp.c              | 29 +++++++++++++++++++++++
hw/ppc/spapr.c               |  2 +-
hw/usb/dev-storage-bot.c     |  1 +
hw/usb/dev-storage-classic.c |  1 +
hw/usb/dev-uas.c             |  1 +
hw/usb/host-libusb.c         | 38 ++++++++----------------------
hw/usb/host-stub.c           | 45 ------------------------------------
monitor/hmp.c                |  7 ++++++
monitor/misc.c               | 33 ++++++++++++--------------
accel/tcg/meson.build        |  1 +
hmp-commands-info.hx         |  3 ---
hw/usb/meson.build           | 10 ++++----
14 files changed, 80 insertions(+), 101 deletions(-)
create mode 100644 accel/tcg/hmp.c
delete mode 100644 hw/usb/host-stub.c
[PATCH 0/5] [RfC] monitor/hmp: command register support
Posted by Gerd Hoffmann 2 years, 10 months ago
Helps making qemu more modular,
see commit messages for details.

Depends on the "modules: add meta-data database" patch series.

Gerd Hoffmann (5):
  monitor: allow register hmp commands
  usb: drop usb_host_dev_is_scsi_storage hook
  monitor/usb: register 'info usbhost' dynamically
  usb: build usb-host as module
  monitor/tcg: move tcg hmp commands to accel/tcg, register them
    dynamically

 include/hw/usb.h             |  7 +++++-
 include/monitor/monitor.h    |  3 +++
 accel/tcg/hmp.c              | 29 +++++++++++++++++++++++
 hw/ppc/spapr.c               |  2 +-
 hw/usb/dev-storage-bot.c     |  1 +
 hw/usb/dev-storage-classic.c |  1 +
 hw/usb/dev-uas.c             |  1 +
 hw/usb/host-libusb.c         | 38 ++++++++----------------------
 hw/usb/host-stub.c           | 45 ------------------------------------
 monitor/hmp.c                |  7 ++++++
 monitor/misc.c               | 33 ++++++++++++--------------
 accel/tcg/meson.build        |  1 +
 hmp-commands-info.hx         |  3 ---
 hw/usb/meson.build           | 10 ++++----
 14 files changed, 80 insertions(+), 101 deletions(-)
 create mode 100644 accel/tcg/hmp.c
 delete mode 100644 hw/usb/host-stub.c

-- 
2.31.1



Re: [PATCH 0/5] [RfC] monitor/hmp: command register support
Posted by Markus Armbruster 2 years, 9 months ago
Gerd Hoffmann <kraxel@redhat.com> writes:

> Helps making qemu more modular,
> see commit messages for details.
>
> Depends on the "modules: add meta-data database" patch series.

This series is about HMP.  Do we have equivalent functionality for QMP
already?

I apologize for not looking at this sooner.


Re: [PATCH 0/5] [RfC] monitor/hmp: command register support
Posted by Gerd Hoffmann 2 years, 8 months ago
On Sat, Aug 07, 2021 at 12:36:13PM +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> > Helps making qemu more modular,
> > see commit messages for details.
> >
> > Depends on the "modules: add meta-data database" patch series.
> 
> This series is about HMP.  Do we have equivalent functionality for QMP
> already?

Didn't check as the commands I've needed it this for are hmp-only.
But, yes, when going forward with building more code modular we might
need this for qmp too at some point ...

take care,
  Gerd