[v4] target/s390x: Fix SIGILL psw.addr reporting

[PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting

Ilya Leoshkevich posted 2 patches 2 years, 10 months ago

Diff against v2 v3
Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210621223217.3642303-1-iii@linux.ibm.com

Maintainers: Cornelia Huck <cohuck@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <laurent@vivier.eu>

linux-user/s390x/cpu_loop.c     |  23 ++++-
target/s390x/excp_helper.c      |  71 +++++++-------
target/s390x/internal.h         |   1 +
target/s390x/mem_helper.c       |   2 +-
tests/tcg/s390x/Makefile.target |   1 +
tests/tcg/s390x/signal.c        | 165 ++++++++++++++++++++++++++++++++
6 files changed, 226 insertions(+), 37 deletions(-)
create mode 100644 tests/tcg/s390x/signal.c

Expand all Fold all

[PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting

Posted by Ilya Leoshkevich 2 years, 10 months ago

qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it
should be a pointer to the instruction following the illegal
instruction, but at the moment it is a pointer to the illegal
instruction itself. This breaks OpenJDK, which relies on this value.

Patch 1 fixes the issue, patch 2 adds a test.

v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06592.html
v1 -> v2: Use a better buglink (Cornelia), simplify the inline asm
          magic in the test and add an explanation (David).

v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06649.html
v2 -> v3: Fix SIGSEGV handling (found when trying to run valgrind under
          qemu-user).

v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg00299.html
v3 -> v4: Fix compiling the test on Ubuntu 20.04 (Jonathan).

Note: the SIGFPE issue is being fixed separately.
https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg05690.html 

Ilya Leoshkevich (2):
  target/s390x: Fix SIGILL psw.addr reporting
  tests/tcg/s390x: Test SIGILL and SIGSEGV handling

 linux-user/s390x/cpu_loop.c     |  23 ++++-
 target/s390x/excp_helper.c      |  71 +++++++-------
 target/s390x/internal.h         |   1 +
 target/s390x/mem_helper.c       |   2 +-
 tests/tcg/s390x/Makefile.target |   1 +
 tests/tcg/s390x/signal.c        | 165 ++++++++++++++++++++++++++++++++
 6 files changed, 226 insertions(+), 37 deletions(-)
 create mode 100644 tests/tcg/s390x/signal.c

-- 
2.31.1

Re: [PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting

Posted by no-reply@patchew.org 2 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/20210621223217.3642303-1-iii@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210621223217.3642303-1-iii@linux.ibm.com
Subject: [PATCH v4 0/2] target/s390x: Fix SIGILL psw.addr reporting

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210614083800.1166166-1-richard.henderson@linaro.org -> patchew/20210614083800.1166166-1-richard.henderson@linaro.org
 - [tag update]      patchew/20210620213249.1494274-1-richard.henderson@linaro.org -> patchew/20210620213249.1494274-1-richard.henderson@linaro.org
 - [tag update]      patchew/20210621152120.4465-1-alex.bennee@linaro.org -> patchew/20210621152120.4465-1-alex.bennee@linaro.org
 * [new tag]         patchew/20210621223217.3642303-1-iii@linux.ibm.com -> patchew/20210621223217.3642303-1-iii@linux.ibm.com
Switched to a new branch 'test'
a51bd28 tests/tcg/s390x: Test SIGILL and SIGSEGV handling
78ea9f7 target/s390x: Fix SIGILL psw.addr reporting

=== OUTPUT BEGIN ===
1/2 Checking commit 78ea9f744a64 (target/s390x: Fix SIGILL psw.addr reporting)
2/2 Checking commit a51bd281a9b9 (tests/tcg/s390x: Test SIGILL and SIGSEGV handling)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

ERROR: externs should be avoided in .c files
#44: FILE: tests/tcg/s390x/signal.c:14:
+void illegal_op(void);

ERROR: externs should be avoided in .c files
#45: FILE: tests/tcg/s390x/signal.c:15:
+void after_illegal_op(void);

ERROR: externs should be avoided in .c files
#51: FILE: tests/tcg/s390x/signal.c:21:
+void stg(void *dst, unsigned long src);

ERROR: externs should be avoided in .c files
#56: FILE: tests/tcg/s390x/signal.c:26:
+void mvc_8(void *dst, void *src);

total: 4 errors, 1 warnings, 169 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210621223217.3642303-1-iii@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com