[PATCH 2/2] coverity-scan: Add 'sysemu' component

Philippe Mathieu-Daudé posted 2 patches 4 years, 7 months ago
There is a newer version of this series
[PATCH 2/2] coverity-scan: Add 'sysemu' component
Posted by Philippe Mathieu-Daudé 4 years, 7 months ago
Issues related to system emulation currently appear under the 'tcg'
component. We commonly refer to system emulation as 'sysemu', so
add it as a new Coverity component to cover files that have nothing
to do with TCG.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/coverity-scan/COMPONENTS.md | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
index 183f26a32c9..7ed3f0a0077 100644
--- a/scripts/coverity-scan/COMPONENTS.md
+++ b/scripts/coverity-scan/COMPONENTS.md
@@ -115,7 +115,7 @@ slirp
   ~ (/qemu)?(/.*slirp.*)
 
 tcg
-  ~ (/qemu)?(/accel/tcg/.*|/replay/.*|/(.*/)?softmmu.*)
+  ~ (/qemu)?(/accel/tcg/.*|/replay/.*|tcg/*\.?)
 
 trace
   ~ (/qemu)?(/.*trace.*\.[ch])
@@ -129,6 +129,9 @@ usb
 user
   ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
 
+sysemu
+  ~ (/qemu)?(/softmmu/.*|/accel/(hvf|kvm)/.*)
+
 util
   ~ (/qemu)?(/util/.*|/include/qemu/.*)
 
-- 
2.31.1

Re: [PATCH 2/2] coverity-scan: Add 'sysemu' component
Posted by Peter Maydell 4 years, 7 months ago
On Sat, 19 Jun 2021 at 10:13, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Issues related to system emulation currently appear under the 'tcg'
> component. We commonly refer to system emulation as 'sysemu', so
> add it as a new Coverity component to cover files that have nothing
> to do with TCG.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/coverity-scan/COMPONENTS.md | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index 183f26a32c9..7ed3f0a0077 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -115,7 +115,7 @@ slirp
>    ~ (/qemu)?(/.*slirp.*)
>
>  tcg
> -  ~ (/qemu)?(/accel/tcg/.*|/replay/.*|/(.*/)?softmmu.*)
> +  ~ (/qemu)?(/accel/tcg/.*|/replay/.*|tcg/*\.?)

Makes sense not to call softmmu/ part of "TCG"...

>
>  trace
>    ~ (/qemu)?(/.*trace.*\.[ch])
> @@ -129,6 +129,9 @@ usb
>  user
>    ~ (/qemu)?(/linux-user/.*|/bsd-user/.*|/user-exec\.c|/thunk\.c|/include/exec/user/.*)
>
> +sysemu
> +  ~ (/qemu)?(/softmmu/.*|/accel/(hvf|kvm)/.*)
> +

...but maybe we should have a component for each accelerator
instead of lumping hvf and kvm under here ? We already have
components for xen and tcg.

>  util
>    ~ (/qemu)?(/util/.*|/include/qemu/.*)
>
> --
> 2.31.1

thanks
-- PMM