configure | 22 +---------- meson.build | 2 +- include/qemu/compiler.h | 51 ------------------------- include/qemu/lockable.h | 90 +++++++++++++++++++++------------------------ include/qemu/thread-posix.h | 14 ++++--- include/qemu/thread-win32.h | 6 --- include/qemu/thread.h | 15 +++++++- fpu/softfloat.c | 16 +++++--- util/qemu-thread-posix.c | 24 +++++++++++- util/qemu-thread-win32.c | 2 +- 10 files changed, 98 insertions(+), 144 deletions(-)
The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2:
Merge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-06-14 15:59:13 +0100)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-c11-20210615
for you to fetch changes up to c7a7cb5692690ad621b6eb2d1c7256907ff45d67:
configure: Remove probe for _Static_assert (2021-06-15 18:31:00 -0700)
----------------------------------------------------------------
Change to -std=gnu11.
Replace QEMU_GENERIC with _Generic.
Remove configure detect of _Static_assert.
----------------------------------------------------------------
Richard Henderson (8):
configure: Use -std=gnu11
softfloat: Use _Generic instead of QEMU_GENERIC
util: Use real functions for thread-posix QemuRecMutex
util: Pass file+line to qemu_rec_mutex_unlock_impl
util: Use unique type for QemuRecMutex in thread-posix.h
include/qemu/lockable: Use _Generic instead of QEMU_GENERIC
qemu/compiler: Remove QEMU_GENERIC
configure: Remove probe for _Static_assert
configure | 22 +----------
meson.build | 2 +-
include/qemu/compiler.h | 51 -------------------------
include/qemu/lockable.h | 90 +++++++++++++++++++++------------------------
include/qemu/thread-posix.h | 14 ++++---
include/qemu/thread-win32.h | 6 ---
include/qemu/thread.h | 15 +++++++-
fpu/softfloat.c | 16 +++++---
util/qemu-thread-posix.c | 24 +++++++++++-
util/qemu-thread-win32.c | 2 +-
10 files changed, 98 insertions(+), 144 deletions(-)
Patchew URL: https://patchew.org/QEMU/20210616013629.1458790-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210616013629.1458790-1-richard.henderson@linaro.org
Subject: [PULL 0/8] configure: Change to -std=gnu11
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210616013629.1458790-1-richard.henderson@linaro.org -> patchew/20210616013629.1458790-1-richard.henderson@linaro.org
Switched to a new branch 'test'
360606f configure: Remove probe for _Static_assert
e641e6f qemu/compiler: Remove QEMU_GENERIC
3b4a4b0 include/qemu/lockable: Use _Generic instead of QEMU_GENERIC
01b2566 util: Use unique type for QemuRecMutex in thread-posix.h
24f3e28 util: Pass file+line to qemu_rec_mutex_unlock_impl
ce5376c util: Use real functions for thread-posix QemuRecMutex
21c8d81 softfloat: Use _Generic instead of QEMU_GENERIC
de2d9e7 configure: Use -std=gnu11
=== OUTPUT BEGIN ===
1/8 Checking commit de2d9e703f2a (configure: Use -std=gnu11)
2/8 Checking commit 21c8d81506d8 (softfloat: Use _Generic instead of QEMU_GENERIC)
ERROR: spaces required around that '*' (ctx:WxO)
#25: FILE: fpu/softfloat.c:689:
+ _Generic((P), FloatParts64 *: parts64_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#25: FILE: fpu/softfloat.c:689:
+ _Generic((P), FloatParts64 *: parts64_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#26: FILE: fpu/softfloat.c:690:
+ FloatParts128 *: parts128_##NAME)
^
ERROR: spaces required around that ':' (ctx:OxW)
#26: FILE: fpu/softfloat.c:690:
+ FloatParts128 *: parts128_##NAME)
^
ERROR: spaces required around that '*' (ctx:WxO)
#31: FILE: fpu/softfloat.c:693:
+ _Generic((P), FloatParts64 *: parts64_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#31: FILE: fpu/softfloat.c:693:
+ _Generic((P), FloatParts64 *: parts64_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#32: FILE: fpu/softfloat.c:694:
+ FloatParts128 *: parts128_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#32: FILE: fpu/softfloat.c:694:
+ FloatParts128 *: parts128_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#33: FILE: fpu/softfloat.c:695:
+ FloatParts256 *: parts256_##NAME)
^
ERROR: spaces required around that ':' (ctx:OxW)
#33: FILE: fpu/softfloat.c:695:
+ FloatParts256 *: parts256_##NAME)
^
ERROR: spaces required around that '*' (ctx:WxO)
#42: FILE: fpu/softfloat.c:897:
+ _Generic((P), FloatParts64 *: frac64_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#42: FILE: fpu/softfloat.c:897:
+ _Generic((P), FloatParts64 *: frac64_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#43: FILE: fpu/softfloat.c:898:
+ FloatParts128 *: frac128_##NAME)
^
ERROR: spaces required around that ':' (ctx:OxW)
#43: FILE: fpu/softfloat.c:898:
+ FloatParts128 *: frac128_##NAME)
^
ERROR: spaces required around that '*' (ctx:WxO)
#48: FILE: fpu/softfloat.c:901:
+ _Generic((P), FloatParts64 *: frac64_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#48: FILE: fpu/softfloat.c:901:
+ _Generic((P), FloatParts64 *: frac64_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#49: FILE: fpu/softfloat.c:902:
+ FloatParts128 *: frac128_##NAME, \
^
ERROR: spaces required around that ':' (ctx:OxW)
#49: FILE: fpu/softfloat.c:902:
+ FloatParts128 *: frac128_##NAME, \
^
ERROR: spaces required around that '*' (ctx:WxO)
#50: FILE: fpu/softfloat.c:903:
+ FloatParts256 *: frac256_##NAME)
^
ERROR: spaces required around that ':' (ctx:OxW)
#50: FILE: fpu/softfloat.c:903:
+ FloatParts256 *: frac256_##NAME)
^
total: 20 errors, 0 warnings, 32 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit ce5376c09e40 (util: Use real functions for thread-posix QemuRecMutex)
WARNING: line over 80 characters
#66: FILE: include/qemu/thread.h:34:
+int qemu_rec_mutex_trylock_impl(QemuRecMutex *mutex, const char *file, int line);
total: 0 errors, 1 warnings, 69 lines checked
Patch 3/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/8 Checking commit 24f3e281639a (util: Pass file+line to qemu_rec_mutex_unlock_impl)
WARNING: line over 80 characters
#30: FILE: include/qemu/thread.h:35:
+void qemu_rec_mutex_unlock_impl(QemuRecMutex *mutex, const char *file, int line);
total: 0 errors, 1 warnings, 47 lines checked
Patch 4/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/8 Checking commit 01b2566dd9e7 (util: Use unique type for QemuRecMutex in thread-posix.h)
6/8 Checking commit 3b4a4b076266 (include/qemu/lockable: Use _Generic instead of QEMU_GENERIC)
ERROR: spaces required around that '*' (ctx:WxO)
#120: FILE: include/qemu/lockable.h:70:
+ _Generic((x), QemuLockable *: (x), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#120: FILE: include/qemu/lockable.h:70:
+ _Generic((x), QemuLockable *: (x), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#121: FILE: include/qemu/lockable.h:71:
+ void *: qemu_null_lockable(x), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#121: FILE: include/qemu/lockable.h:71:
+ void *: qemu_null_lockable(x), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#122: FILE: include/qemu/lockable.h:72:
+ QemuMutex *: qemu_make_lockable(x, QML_OBJ_(x, mutex)), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#122: FILE: include/qemu/lockable.h:72:
+ QemuMutex *: qemu_make_lockable(x, QML_OBJ_(x, mutex)), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#123: FILE: include/qemu/lockable.h:73:
+ QemuRecMutex *: qemu_make_lockable(x, QML_OBJ_(x, rec_mutex)), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#123: FILE: include/qemu/lockable.h:73:
+ QemuRecMutex *: qemu_make_lockable(x, QML_OBJ_(x, rec_mutex)), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#124: FILE: include/qemu/lockable.h:74:
+ CoMutex *: qemu_make_lockable(x, QML_OBJ_(x, co_mutex)), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#124: FILE: include/qemu/lockable.h:74:
+ CoMutex *: qemu_make_lockable(x, QML_OBJ_(x, co_mutex)), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#125: FILE: include/qemu/lockable.h:75:
+ QemuSpin *: qemu_make_lockable(x, QML_OBJ_(x, spin)))
^
ERROR: spaces required around that ':' (ctx:OxW)
#125: FILE: include/qemu/lockable.h:75:
+ QemuSpin *: qemu_make_lockable(x, QML_OBJ_(x, spin)))
^
ERROR: spaces required around that '*' (ctx:WxO)
#141: FILE: include/qemu/lockable.h:87:
+ _Generic((x), QemuLockable *: (x), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#141: FILE: include/qemu/lockable.h:87:
+ _Generic((x), QemuLockable *: (x), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#142: FILE: include/qemu/lockable.h:88:
+ QemuMutex *: QML_OBJ_(x, mutex), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#142: FILE: include/qemu/lockable.h:88:
+ QemuMutex *: QML_OBJ_(x, mutex), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#143: FILE: include/qemu/lockable.h:89:
+ QemuRecMutex *: QML_OBJ_(x, rec_mutex), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#143: FILE: include/qemu/lockable.h:89:
+ QemuRecMutex *: QML_OBJ_(x, rec_mutex), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#144: FILE: include/qemu/lockable.h:90:
+ CoMutex *: QML_OBJ_(x, co_mutex), \
^
ERROR: spaces required around that ':' (ctx:OxW)
#144: FILE: include/qemu/lockable.h:90:
+ CoMutex *: QML_OBJ_(x, co_mutex), \
^
ERROR: spaces required around that '*' (ctx:WxO)
#145: FILE: include/qemu/lockable.h:91:
+ QemuSpin *: QML_OBJ_(x, spin))
^
ERROR: spaces required around that ':' (ctx:OxW)
#145: FILE: include/qemu/lockable.h:91:
+ QemuSpin *: QML_OBJ_(x, spin))
^
total: 22 errors, 0 warnings, 120 lines checked
Patch 6/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/8 Checking commit e641e6fac8c1 (qemu/compiler: Remove QEMU_GENERIC)
8/8 Checking commit 360606fa610e (configure: Remove probe for _Static_assert)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210616013629.1458790-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Wed, 16 Jun 2021 at 02:36, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2: > > Merge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-06-14 15:59:13 +0100) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-c11-20210615 > > for you to fetch changes up to c7a7cb5692690ad621b6eb2d1c7256907ff45d67: > > configure: Remove probe for _Static_assert (2021-06-15 18:31:00 -0700) > > ---------------------------------------------------------------- > Change to -std=gnu11. > Replace QEMU_GENERIC with _Generic. > Remove configure detect of _Static_assert. > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM
© 2016 - 2026 Red Hat, Inc.