[v1] target/i386/sev: Housekeeping helping using SEV-disabled binaries

[PATCH 04/11] target/i386/cpu: Add missing 'qapi/error.h' header

Posted by Philippe Mathieu-Daudé 4 years, 8 months ago

Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
forgot to add the "qapi/error.h", add it now.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 target/i386/cpu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index a9fe1662d39..694031e4aec 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -27,6 +27,7 @@
 #include "sysemu/hvf.h"
 #include "kvm/kvm_i386.h"
 #include "sev_i386.h"
+#include "qapi/error.h"
 #include "qapi/qapi-visit-machine.h"
 #include "qapi/qmp/qerror.h"
 #include "qapi/qapi-commands-machine-target.h"
-- 
2.31.1

Re: [PATCH 04/11] target/i386/cpu: Add missing 'qapi/error.h' header

Posted by Connor Kuehl 4 years, 8 months ago

On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
> forgot to add the "qapi/error.h", add it now.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Connor Kuehl <ckuehl@redhat.com>

Re: [PATCH 04/11] target/i386/cpu: Add missing 'qapi/error.h' header

Posted by Dr. David Alan Gilbert 4 years, 8 months ago

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
> forgot to add the "qapi/error.h", add it now.

for the error_abort I guess

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  target/i386/cpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index a9fe1662d39..694031e4aec 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -27,6 +27,7 @@
>  #include "sysemu/hvf.h"
>  #include "kvm/kvm_i386.h"
>  #include "sev_i386.h"
> +#include "qapi/error.h"
>  #include "qapi/qapi-visit-machine.h"
>  #include "qapi/qmp/qerror.h"
>  #include "qapi/qapi-commands-machine-target.h"
> -- 
> 2.31.1
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK